Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 2477143002: Revert of [Tracing] Use TracingCategoryObserver in gc statistics (Closed)

Created:
4 years, 1 month ago by Michael Achenbach
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [Tracing] Use TracingCategoryObserver in gc statistics (patchset #5 id:100001 of https://codereview.chromium.org/2459903003/ ) Reason for revert: Speculative revert for blocking roll: https://codereview.chromium.org/2473003006/ E.g.: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/331898 Original issue's description: > [Tracing] Use TracingCategoryObserver in gc statistics > > This patch is a follow-up patch to enable gc statistics to use > TracingCategoryObserver. > > Previously we need to pass --track_gc_object_stats to v8 if we want to enable > gc statistics in tracing. In this patch, we introducce an integer flag > FLAG_gc_stats, and FLAG_track_gc_object_stats and FLAG_trace_gc_object_stats > will set it to 0x01, tracing will set it to 0x10 when we start tracing and > reset the bit when we stop tracing. > > BUG=v8:5590 TBR=fmeawad@chromium.org,mlippautz@chromium.org,lpy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5590 Committed: https://crrev.com/146c52ef2c9fb9e2b60615d84c67dfd864dedecb Cr-Commit-Position: refs/heads/master@{#40785}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -41 lines) Patch
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/d8.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/heap/heap.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap-inl.h View 2 chunks +0 lines, -11 lines 0 comments Download
M src/heap/mark-compact.cc View 2 chunks +8 lines, -13 lines 0 comments Download
M src/tracing/tracing-category-observer.cc View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [Tracing] Use TracingCategoryObserver in gc statistics
4 years, 1 month ago (2016-11-05 13:27:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2477143002/1
4 years, 1 month ago (2016-11-05 13:27:15 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-05 13:27:30 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:23:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/146c52ef2c9fb9e2b60615d84c67dfd864dedecb
Cr-Commit-Position: refs/heads/master@{#40785}

Powered by Google App Engine
This is Rietveld 408576698