Separate repaint and layout requirements of StyleDifference (Step 3)

Source/core/rendering/svg/SVGResourcesCache.cpp

Index: Source/core/rendering/svg/SVGResourcesCache.cpp
diff --git a/Source/core/rendering/svg/SVGResourcesCache.cpp b/Source/core/rendering/svg/SVGResourcesCache.cpp
index 0c131a0aabb78e49315cc54f71b2d064ea52c9d2..58b1a41f777c7b70d720d426e834566fbaf4f73d 100644
--- a/Source/core/rendering/svg/SVGResourcesCache.cpp
+++ b/Source/core/rendering/svg/SVGResourcesCache.cpp
@@ -126,7 +126,7 @@ void SVGResourcesCache::clientStyleChanged(RenderObject* renderer, StyleDifferen
         return;
 
     // In this case the proper SVGFE*Element will decide whether the modified CSS properties require a relayout or repaint.
-    if (renderer->isSVGResourceFilterPrimitive() && diff.needsRepaintObjectOnly())
+    if (renderer->isSVGResourceFilterPrimitive() && !diff.needsLayout())

[Julien - ping for review, 2014/04/25 15:43:04]

This change is a no-op (SVG elements don't have layers and they don't use the
optimized layout bits) but it obfuscates what the code really does.

[Xianzhu, 2014/04/25 17:32:39]

StyleDifference now allows needsFullLayout() and needsRepaintObject() to be set
independently, and SVGRenderStyle::diff() may set both of them in the next steps
to express repaint needs explicitly even if needsFullLayout.

I think the code is like "if (!needsRepaint()) return; else
doSthNeededWhenNeedsLayout;", so using !diff.needsLayout() here seems clearer.

[Julien - ping for review, 2014/04/28 17:40:28]

OK

         return;
 
     // Dynamic changes of CSS properties like 'clip-path' may require us to recompute the associated resources for a renderer.