Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2477033002: fix swarmbucket infra path (Closed)

Created:
4 years, 1 month ago by nodir
Modified:
4 years, 1 month ago
Reviewers:
Vadim Sh., martiniss
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix swarmbucket infra path Do not rely on buildbot config which goes up 4 directories. Everything should happen in the workdir. Also exclude any project-specific paths. This fixes the problem that swarmbucket builds expect git_cache to be in /b/git_cache. It should be in the CWD/git_cache. This will fix Windows builders. R=vadimsh@chromium.org BUG= Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/b8b5aaea9217f0a2e0b9a48bfa6e6fc054d74d23

Patch Set 1 #

Patch Set 2 : tuple #

Patch Set 3 : update example #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M recipe_modules/infra_paths/example.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/infra_paths/example.expected/basic.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/infra_paths/example.expected/paths_buildbot_linux.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/infra_paths/example.expected/paths_buildbot_mac.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/infra_paths/example.expected/paths_buildbot_win.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/infra_paths/example.expected/paths_kitchen_linux.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/infra_paths/example.expected/paths_kitchen_mac.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/infra_paths/example.expected/paths_kitchen_win.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/infra_paths/example.expected/paths_swarmbucket_linux.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/infra_paths/example.expected/paths_swarmbucket_mac.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/infra_paths/example.expected/paths_swarmbucket_win.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/infra_paths/path_config.py View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 21 (10 generated)
nodir
PTAL
4 years, 1 month ago (2016-11-04 21:05:31 UTC) #1
nodir
it broke when kitchen started to fetch recipes using recipe-engine's remote subcommand
4 years, 1 month ago (2016-11-04 21:06:07 UTC) #2
martiniss
lgtm
4 years, 1 month ago (2016-11-04 21:10:37 UTC) #5
Vadim Sh.
rs lgtm
4 years, 1 month ago (2016-11-04 21:11:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2477033002/1
4 years, 1 month ago (2016-11-04 21:11:28 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Depot Tools Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/324a005076e87b10)
4 years, 1 month ago (2016-11-04 21:17:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2477033002/20001
4 years, 1 month ago (2016-11-04 21:22:48 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: Depot Tools Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/324a0aaec2163310)
4 years, 1 month ago (2016-11-04 21:28:39 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2477033002/40001
4 years, 1 month ago (2016-11-04 21:32:59 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/tools/depot_tools/+/b8b5aaea9217f0a2e0b9a48bfa6e6fc054d74d23
4 years, 1 month ago (2016-11-04 21:36:18 UTC) #20
martiniss
4 years, 1 month ago (2016-11-04 22:51:02 UTC) #21
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2484433002/ by martiniss@chromium.org.

The reason for reverting is: Broke build CQ:
https://luci-milo.appspot.com/swarming/task/324a5636a5cfdf10/steps/Uncaught_E....

Powered by Google App Engine
This is Rietveld 408576698