Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2477013003:
Replace flaky smoke test (Closed)
DescriptionReplace flaky PNG smoke test
The removed test is a bit slow, which I suspect is
causing flaky behavior on Android. The test that
is replacing it provides coverage of png decoding
and color correction.
BUG=657839
BUG=661769
Committed: https://crrev.com/373093497c9ebca029a707a8d9fee5e57e3d2af6
Committed: https://crrev.com/a735030f7123aa550409b6dcdd58fee3faa0d5f9
Cr-Original-Commit-Position: refs/heads/master@{#430270}
Cr-Commit-Position: refs/heads/master@{#430627}
Patch Set 1 #Patch Set 2 : Rebaseline #Patch Set 3 : Rebase #
Messages
Total messages: 30 (18 generated)
Description was changed from ========== Replace flaky smoke test BUG=657839 BUG=661769 ========== to ========== Replace flaky smoke test The removed test is a bit slow, which I suspect is causing flaky behavior on Android. The test that is replacing it provides coverage of png decoding and color correction. BUG=657839 BUG=661769 ==========
Description was changed from ========== Replace flaky smoke test The removed test is a bit slow, which I suspect is causing flaky behavior on Android. The test that is replacing it provides coverage of png decoding and color correction. BUG=657839 BUG=661769 ========== to ========== Replace flaky PNG smoke test The removed test is a bit slow, which I suspect is causing flaky behavior on Android. The test that is replacing it provides coverage of png decoding and color correction. BUG=657839 BUG=661769 ==========
msarett@chromium.org changed reviewers: + dpranke@chromium.org, msarett@chromium.org
lgtm
The CQ bit was checked by msarett@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Replace flaky PNG smoke test The removed test is a bit slow, which I suspect is causing flaky behavior on Android. The test that is replacing it provides coverage of png decoding and color correction. BUG=657839 BUG=661769 ========== to ========== Replace flaky PNG smoke test The removed test is a bit slow, which I suspect is causing flaky behavior on Android. The test that is replacing it provides coverage of png decoding and color correction. BUG=657839 BUG=661769 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Replace flaky PNG smoke test The removed test is a bit slow, which I suspect is causing flaky behavior on Android. The test that is replacing it provides coverage of png decoding and color correction. BUG=657839 BUG=661769 ========== to ========== Replace flaky PNG smoke test The removed test is a bit slow, which I suspect is causing flaky behavior on Android. The test that is replacing it provides coverage of png decoding and color correction. BUG=657839 BUG=661769 Committed: https://crrev.com/373093497c9ebca029a707a8d9fee5e57e3d2af6 Cr-Commit-Position: refs/heads/master@{#430270} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/373093497c9ebca029a707a8d9fee5e57e3d2af6 Cr-Commit-Position: refs/heads/master@{#430270}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2479253002/ by msarett@google.com. The reason for reverting is: Still breaking the Android bot.
Message was sent while issue was closed.
lgtm
Message was sent while issue was closed.
Description was changed from ========== Replace flaky PNG smoke test The removed test is a bit slow, which I suspect is causing flaky behavior on Android. The test that is replacing it provides coverage of png decoding and color correction. BUG=657839 BUG=661769 Committed: https://crrev.com/373093497c9ebca029a707a8d9fee5e57e3d2af6 Cr-Commit-Position: refs/heads/master@{#430270} ========== to ========== Replace flaky PNG smoke test The removed test is a bit slow, which I suspect is causing flaky behavior on Android. The test that is replacing it provides coverage of png decoding and color correction. BUG=657839 BUG=661769 Committed: https://crrev.com/373093497c9ebca029a707a8d9fee5e57e3d2af6 Cr-Commit-Position: refs/heads/master@{#430270} ==========
The CQ bit was checked by msarett@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/2477013003/#ps20001 (title: "Rebaseline")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by msarett@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by msarett@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/2477013003/#ps40001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Replace flaky PNG smoke test The removed test is a bit slow, which I suspect is causing flaky behavior on Android. The test that is replacing it provides coverage of png decoding and color correction. BUG=657839 BUG=661769 Committed: https://crrev.com/373093497c9ebca029a707a8d9fee5e57e3d2af6 Cr-Commit-Position: refs/heads/master@{#430270} ========== to ========== Replace flaky PNG smoke test The removed test is a bit slow, which I suspect is causing flaky behavior on Android. The test that is replacing it provides coverage of png decoding and color correction. BUG=657839 BUG=661769 Committed: https://crrev.com/373093497c9ebca029a707a8d9fee5e57e3d2af6 Cr-Commit-Position: refs/heads/master@{#430270} ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Replace flaky PNG smoke test The removed test is a bit slow, which I suspect is causing flaky behavior on Android. The test that is replacing it provides coverage of png decoding and color correction. BUG=657839 BUG=661769 Committed: https://crrev.com/373093497c9ebca029a707a8d9fee5e57e3d2af6 Cr-Commit-Position: refs/heads/master@{#430270} ========== to ========== Replace flaky PNG smoke test The removed test is a bit slow, which I suspect is causing flaky behavior on Android. The test that is replacing it provides coverage of png decoding and color correction. BUG=657839 BUG=661769 Committed: https://crrev.com/373093497c9ebca029a707a8d9fee5e57e3d2af6 Committed: https://crrev.com/a735030f7123aa550409b6dcdd58fee3faa0d5f9 Cr-Original-Commit-Position: refs/heads/master@{#430270} Cr-Commit-Position: refs/heads/master@{#430627} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/a735030f7123aa550409b6dcdd58fee3faa0d5f9 Cr-Commit-Position: refs/heads/master@{#430627} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
