|
|
DescriptionDetect pipelines which can compile to memsets.
Any pipeline that looks like:
- constant_color
- store_fmt
can be trivially converted into an sk_memset of the right size for fmt.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2477013002
Committed: https://skia.googlesource.com/skia/+/125b2aac5a38121b3c82545acd27e74366ca83aa
Patch Set 1 #Patch Set 2 : natty #Messages
Total messages: 18 (12 generated)
Description was changed from ========== Detect pipelines which can compile to memsets. Any pipeline that looks like: - constant_color - store_fmt can be trivially converted into an sk_memset of the right size for fmt. BUG=skia: ========== to ========== Detect pipelines which can compile to memsets. Any pipeline that looks like: - constant_color - store_fmt can be trivially converted into an sk_memset of the right size for fmt. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2477013002 ==========
The CQ bit was checked by mtklein@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...) Build-Mac-Clang-x86_64-Release-GN-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...) Build-Ubuntu-GCC-x86_64-Release-GN-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)
The CQ bit was checked by mtklein@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
mtklein@chromium.org changed reviewers: + reed@google.com
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Test-Android-Clang-Nexus5-GPU-Adreno330-arm-Release-GN_Android-Trybot on master.client.skia.android (JOB_FAILED, http://build.chromium.org/p/client.skia.android/builders/Test-Android-Clang-N...)
The CQ bit was checked by mtklein@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Detect pipelines which can compile to memsets. Any pipeline that looks like: - constant_color - store_fmt can be trivially converted into an sk_memset of the right size for fmt. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2477013002 ========== to ========== Detect pipelines which can compile to memsets. Any pipeline that looks like: - constant_color - store_fmt can be trivially converted into an sk_memset of the right size for fmt. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2477013002 Committed: https://skia.googlesource.com/skia/+/125b2aac5a38121b3c82545acd27e74366ca83aa ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/125b2aac5a38121b3c82545acd27e74366ca83aa
Message was sent while issue was closed.
On 2016/11/04 20:41:38, commit-bot: I haz the power wrote: > Committed patchset #2 (id:20001) as > https://skia.googlesource.com/skia/+/125b2aac5a38121b3c82545acd27e74366ca83aa I'm guessing this is responsible for the perf improvement at https://perf.skia.org/cl/1406 ?
Message was sent while issue was closed.
On 2016/11/09 at 14:48:32, scroggo wrote: > On 2016/11/04 20:41:38, commit-bot: I haz the power wrote: > > Committed patchset #2 (id:20001) as > > https://skia.googlesource.com/skia/+/125b2aac5a38121b3c82545acd27e74366ca83aa > > I'm guessing this is responsible for the perf improvement at https://perf.skia.org/cl/1406 ? Yes, and the step down on the 7th is https://skia.googlesource.com/skia/+/aeb7959fd2d8232846d9d556a42943f8092f1af2 |