Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2477013002: Detect pipelines which can compile to memsets. (Closed)

Created:
4 years, 1 month ago by mtklein_C
Modified:
4 years, 1 month ago
Reviewers:
reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Detect pipelines which can compile to memsets. Any pipeline that looks like: - constant_color - store_fmt can be trivially converted into an sk_memset of the right size for fmt. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2477013002 Committed: https://skia.googlesource.com/skia/+/125b2aac5a38121b3c82545acd27e74366ca83aa

Patch Set 1 #

Patch Set 2 : natty #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M src/opts/SkRasterPipeline_opts.h View 1 2 chunks +27 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
mtklein_C
4 years, 1 month ago (2016-11-04 19:47:38 UTC) #9
reed1
lgtm
4 years, 1 month ago (2016-11-04 20:00:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2477013002/20001
4 years, 1 month ago (2016-11-04 20:18:42 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/125b2aac5a38121b3c82545acd27e74366ca83aa
4 years, 1 month ago (2016-11-04 20:41:38 UTC) #16
scroggo
On 2016/11/04 20:41:38, commit-bot: I haz the power wrote: > Committed patchset #2 (id:20001) as ...
4 years, 1 month ago (2016-11-09 14:48:32 UTC) #17
mtklein_C
4 years, 1 month ago (2016-11-09 14:53:32 UTC) #18
Message was sent while issue was closed.
On 2016/11/09 at 14:48:32, scroggo wrote:
> On 2016/11/04 20:41:38, commit-bot: I haz the power wrote:
> > Committed patchset #2 (id:20001) as
> >
https://skia.googlesource.com/skia/+/125b2aac5a38121b3c82545acd27e74366ca83aa
> 
> I'm guessing this is responsible for the perf improvement at
https://perf.skia.org/cl/1406 ?

Yes, and the step down on the 7th is
https://skia.googlesource.com/skia/+/aeb7959fd2d8232846d9d556a42943f8092f1af2

Powered by Google App Engine
This is Rietveld 408576698