Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 24770002: Fix android_run_skia (Closed)

Created:
7 years, 2 months ago by borenet
Modified:
7 years, 2 months ago
Reviewers:
jvanverth1, djsollen
CC:
skia-review_googlegroups.com, jvanverth1
Visibility:
Public.

Description

Fix android_run_skia If STATUS_FILENAME doesn't exist, exit 1. R=djsollen@google.com, jvanverth@google.com Committed: https://code.google.com/p/skia/source/detail?r=11498

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M platform_tools/android/bin/android_run_skia View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
borenet
7 years, 2 months ago (2013-09-26 15:24:22 UTC) #1
djsollen
7 years, 2 months ago (2013-09-26 15:30:33 UTC) #2
djsollen
lgtm
7 years, 2 months ago (2013-09-26 15:30:35 UTC) #3
jvanverth1
lgtm
7 years, 2 months ago (2013-09-26 15:48:36 UTC) #4
borenet
Patch set 4: change escaped double quotes to single quotes. Re-uploaded as https://codereview.chromium.org/24800002/ since this ...
7 years, 2 months ago (2013-09-26 19:11:07 UTC) #5
borenet
7 years, 2 months ago (2013-09-27 14:28:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 manually as r11498 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698