Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Unified Diff: components/navigation_metrics/navigation_metrics.cc

Issue 2476993002: Add filesystem scheme to navigation histograms. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/navigation_metrics/navigation_metrics.cc
diff --git a/components/navigation_metrics/navigation_metrics.cc b/components/navigation_metrics/navigation_metrics.cc
index e4c8ed5374942953c8a17cbc9a445471c60affc6..58ae7d033f27be4d4e311b48c909dc1856371946 100644
--- a/components/navigation_metrics/navigation_metrics.cc
+++ b/components/navigation_metrics/navigation_metrics.cc
@@ -23,21 +23,23 @@ enum Scheme {
SCHEME_ABOUT,
SCHEME_CHROME,
SCHEME_BLOB,
+ SCHEME_FILESYSTEM,
SCHEME_MAX,
};
const char* const kSchemeNames[] = {
- "unknown",
- url::kHttpScheme,
- url::kHttpsScheme,
- url::kFileScheme,
- url::kFtpScheme,
- url::kDataScheme,
- url::kJavaScriptScheme,
- url::kAboutScheme,
- "chrome",
- url::kBlobScheme,
- "max",
+ "unknown",
+ url::kHttpScheme,
+ url::kHttpsScheme,
+ url::kFileScheme,
+ url::kFtpScheme,
+ url::kDataScheme,
+ url::kJavaScriptScheme,
+ url::kAboutScheme,
+ "chrome",
+ url::kBlobScheme,
+ url::kFileSystemScheme,
+ "max",
Ilya Sherman 2016/11/04 18:34:30 nit: By the way, I don't think the indentation adj
meacer 2016/11/04 19:11:46 I used git cl format. Should the correct indentati
Ilya Sherman 2016/11/05 00:29:00 Yeah, I would have expected 2 spaces. But, if thi
};
static_assert(arraysize(kSchemeNames) == SCHEME_MAX + 1,
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698