Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 2476993002: Add filesystem scheme to navigation histograms. (Closed)

Created:
4 years, 1 month ago by meacer
Modified:
4 years, 1 month ago
Reviewers:
cbentzel, Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add filesystem scheme to navigation histograms. BUG=594215 Committed: https://crrev.com/a63dba9631de50cc36d24b38ec2e63f6423c6bb8 Cr-Commit-Position: refs/heads/master@{#430346}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M components/navigation_metrics/navigation_metrics.cc View 1 chunk +13 lines, -11 lines 3 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
meacer
cbentzel, isherman: PTAL, thanks.
4 years, 1 month ago (2016-11-04 18:20:50 UTC) #2
Ilya Sherman
histograms.xml lgtm
4 years, 1 month ago (2016-11-04 18:32:50 UTC) #3
Ilya Sherman
https://codereview.chromium.org/2476993002/diff/1/components/navigation_metrics/navigation_metrics.cc File components/navigation_metrics/navigation_metrics.cc (right): https://codereview.chromium.org/2476993002/diff/1/components/navigation_metrics/navigation_metrics.cc#newcode42 components/navigation_metrics/navigation_metrics.cc:42: "max", nit: By the way, I don't think the ...
4 years, 1 month ago (2016-11-04 18:34:30 UTC) #4
meacer
https://codereview.chromium.org/2476993002/diff/1/components/navigation_metrics/navigation_metrics.cc File components/navigation_metrics/navigation_metrics.cc (right): https://codereview.chromium.org/2476993002/diff/1/components/navigation_metrics/navigation_metrics.cc#newcode42 components/navigation_metrics/navigation_metrics.cc:42: "max", On 2016/11/04 18:34:30, Ilya Sherman wrote: > nit: ...
4 years, 1 month ago (2016-11-04 19:11:46 UTC) #5
Ilya Sherman
https://codereview.chromium.org/2476993002/diff/1/components/navigation_metrics/navigation_metrics.cc File components/navigation_metrics/navigation_metrics.cc (right): https://codereview.chromium.org/2476993002/diff/1/components/navigation_metrics/navigation_metrics.cc#newcode42 components/navigation_metrics/navigation_metrics.cc:42: "max", On 2016/11/04 19:11:46, Mustafa Emre Acer wrote: > ...
4 years, 1 month ago (2016-11-05 00:29:00 UTC) #6
cbentzel
On 2016/11/05 00:29:00, Ilya Sherman wrote: > https://codereview.chromium.org/2476993002/diff/1/components/navigation_metrics/navigation_metrics.cc > File components/navigation_metrics/navigation_metrics.cc (right): > > https://codereview.chromium.org/2476993002/diff/1/components/navigation_metrics/navigation_metrics.cc#newcode42 ...
4 years, 1 month ago (2016-11-07 15:26:03 UTC) #7
meacer
Thanks!
4 years, 1 month ago (2016-11-07 18:22:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2476993002/1
4 years, 1 month ago (2016-11-07 18:23:02 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-07 19:35:04 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 19:46:39 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a63dba9631de50cc36d24b38ec2e63f6423c6bb8
Cr-Commit-Position: refs/heads/master@{#430346}

Powered by Google App Engine
This is Rietveld 408576698