Add filesystem scheme to navigation histograms.

Add filesystem scheme to navigation histograms.

BUG=594215
Committed: https://crrev.com/a63dba9631de50cc36d24b38ec2e63f6423c6bb8
Cr-Commit-Position: refs/heads/master@{#430346}

[meacer, 2016-11-04 18:20:50]

meacer@chromium.org changed reviewers:
+ cbentzel@chromium.org, isherman@chromium.org

[meacer, 2016-11-04 18:20:50]

cbentzel, isherman: PTAL, thanks.

[Ilya Sherman, 2016-11-04 18:32:50]

histograms.xml lgtm

[Ilya Sherman, 2016-11-04 18:34:30]

https://codereview.chromium.org/2476993002/diff/1/components/navigation_metri...
File components/navigation_metrics/navigation_metrics.cc (right):

https://codereview.chromium.org/2476993002/diff/1/components/navigation_metri...
components/navigation_metrics/navigation_metrics.cc:42: "max",
nit: By the way, I don't think the indentation adjustment here is correct.  Is
this a result of "git cl format", or a manual edit?  (If it's git cl format,
then it might be worth filing a git cl format bug, but mostly you can ignore my
comment.)

[meacer, 2016-11-04 19:11:46]

https://codereview.chromium.org/2476993002/diff/1/components/navigation_metri...
File components/navigation_metrics/navigation_metrics.cc (right):

https://codereview.chromium.org/2476993002/diff/1/components/navigation_metri...
components/navigation_metrics/navigation_metrics.cc:42: "max",
On 2016/11/04 18:34:30, Ilya Sherman wrote:
> nit: By the way, I don't think the indentation adjustment here is correct.  Is
> this a result of "git cl format", or a manual edit?  (If it's git cl format,
> then it might be worth filing a git cl format bug, but mostly you can ignore
my
> comment.)

I used git cl format. Should the correct indentation be 2 spaces? It looks like
there is existing 4 space examples in the codebase too:
https://cs.chromium.org/chromium/src/net/dns/mdns_client_unittest.cc?q=k%5Ba-...

[Ilya Sherman, 2016-11-05 00:29:00]

https://codereview.chromium.org/2476993002/diff/1/components/navigation_metri...
File components/navigation_metrics/navigation_metrics.cc (right):

https://codereview.chromium.org/2476993002/diff/1/components/navigation_metri...
components/navigation_metrics/navigation_metrics.cc:42: "max",
On 2016/11/04 19:11:46, Mustafa Emre Acer wrote:
> On 2016/11/04 18:34:30, Ilya Sherman wrote:
> > nit: By the way, I don't think the indentation adjustment here is correct. 
Is
> > this a result of "git cl format", or a manual edit?  (If it's git cl format,
> > then it might be worth filing a git cl format bug, but mostly you can ignore
> my
> > comment.)
> 
> I used git cl format. Should the correct indentation be 2 spaces? It looks
like
> there is existing 4 space examples in the codebase too:
>
https://cs.chromium.org/chromium/src/net/dns/mdns_client_unittest.cc?q=k%5Ba-...

Yeah, I would have expected 2 spaces.  But, if this is git cl format output,
it's probably not worth worrying about too much.  Thanks!

[cbentzel, 2016-11-07 15:26:03]

On 2016/11/05 00:29:00, Ilya Sherman wrote:
>
https://codereview.chromium.org/2476993002/diff/1/components/navigation_metri...
> File components/navigation_metrics/navigation_metrics.cc (right):
> 
>
https://codereview.chromium.org/2476993002/diff/1/components/navigation_metri...
> components/navigation_metrics/navigation_metrics.cc:42: "max",
> On 2016/11/04 19:11:46, Mustafa Emre Acer wrote:
> > On 2016/11/04 18:34:30, Ilya Sherman wrote:
> > > nit: By the way, I don't think the indentation adjustment here is correct.

> Is
> > > this a result of "git cl format", or a manual edit?  (If it's git cl
format,
> > > then it might be worth filing a git cl format bug, but mostly you can
ignore
> > my
> > > comment.)
> > 
> > I used git cl format. Should the correct indentation be 2 spaces? It looks
> like
> > there is existing 4 space examples in the codebase too:
> >
>
https://cs.chromium.org/chromium/src/net/dns/mdns_client_unittest.cc?q=k%5Ba-...
> 
> Yeah, I would have expected 2 spaces.  But, if this is git cl format output,
> it's probably not worth worrying about too much.  Thanks!

LGTM

[meacer, 2016-11-07 18:22:32]

Thanks!

[meacer, 2016-11-07 18:22:36]

The CQ bit was checked by meacer@chromium.org

[commit-bot: I haz the power, 2016-11-07 18:23:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 19:35:04]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-07 19:46:38]

Description was changed from

==========
Add filesystem scheme to navigation histograms.

BUG=594215
==========

to

==========
Add filesystem scheme to navigation histograms.

BUG=594215

Committed: https://crrev.com/a63dba9631de50cc36d24b38ec2e63f6423c6bb8
Cr-Commit-Position: refs/heads/master@{#430346}
==========

[commit-bot: I haz the power, 2016-11-07 19:46:39]

Patchset 1 (id:??) landed as
https://crrev.com/a63dba9631de50cc36d24b38ec2e63f6423c6bb8
Cr-Commit-Position: refs/heads/master@{#430346}