Remove initial_opt_in_ field.

Remove initial_opt_in_ field.

The field is always set before StartUI(), checked in StartUI(),
and is reset. It is just redundant. Removes it.
initial_opt_in_ = false case is migrated into
PrepareContextForAuthCodeRequest(), instead.

BUG=657687
BUG=b/31079732
TEST=Ran on test device. Ran trybots.

Committed: https://crrev.com/0eed93bebd58e2ed526edd3c8fbafc442d07b486
Cr-Commit-Position: refs/heads/master@{#430062}

[hidehiko, 2016-11-04 17:32:55]

The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run

[hidehiko, 2016-11-04 17:33:21]

hidehiko@chromium.org changed reviewers:
+ lhchavez@chromium.org

[hidehiko, 2016-11-04 17:33:22]

PTAL: Luis. FYI: Yury.

[commit-bot: I haz the power, 2016-11-04 17:33:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 19:17:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 19:17:52]

Dry run: This issue passed the CQ dry run.

[Luis Héctor Chávez, 2016-11-04 22:37:54]

https://codereview.chromium.org/2476973003/diff/1/chrome/browser/chromeos/arc...
File chrome/browser/chromeos/arc/arc_auth_service.cc (right):

https://codereview.chromium.org/2476973003/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_auth_service.cc:404:
DCHECK(IsAuthCodeRequest());
How about DCHECK(state_ != State::ACTIVE || IsAuthCodeRequest()); ?
Alternatively, elide the braces.

https://codereview.chromium.org/2476973003/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_auth_service.cc:831:
DCHECK(!arc_bridge_service()->stopped());
DCHECK(arc_bridge_service()->stopped());

[hidehiko, 2016-11-04 22:42:43]

PTAL.

https://codereview.chromium.org/2476973003/diff/1/chrome/browser/chromeos/arc...
File chrome/browser/chromeos/arc/arc_auth_service.cc (right):

https://codereview.chromium.org/2476973003/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_auth_service.cc:404:
DCHECK(IsAuthCodeRequest());
On 2016/11/04 22:37:54, Luis Héctor Chávez wrote:
> How about DCHECK(state_ != State::ACTIVE || IsAuthCodeRequest()); ?
> Alternatively, elide the braces.

Done.

https://codereview.chromium.org/2476973003/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_auth_service.cc:831:
DCHECK(!arc_bridge_service()->stopped());
On 2016/11/04 22:37:54, Luis Héctor Chávez wrote:
> DCHECK(arc_bridge_service()->stopped());

Ugrrr... Good catch. Fixed.

[Luis Héctor Chávez, 2016-11-04 22:44:33]

lgtm

[hidehiko, 2016-11-04 22:45:13]

The CQ bit was checked by hidehiko@chromium.org

[commit-bot: I haz the power, 2016-11-04 22:46:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 23:15:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-04 23:19:09]

Description was changed from

==========
Remove initial_opt_in_ field.

The field is always set before StartUI(), checked in StartUI(),
and is reset. It is just redundant. Removes it.
initial_opt_in_ = false case is migrated into
PrepareContextForAuthCodeRequest(), instead.

BUG=657687
BUG=b/31079732
TEST=Ran on test device. Ran trybots.
==========

to

==========
Remove initial_opt_in_ field.

The field is always set before StartUI(), checked in StartUI(),
and is reset. It is just redundant. Removes it.
initial_opt_in_ = false case is migrated into
PrepareContextForAuthCodeRequest(), instead.

BUG=657687
BUG=b/31079732
TEST=Ran on test device. Ran trybots.

Committed: https://crrev.com/0eed93bebd58e2ed526edd3c8fbafc442d07b486
Cr-Commit-Position: refs/heads/master@{#430062}
==========

[commit-bot: I haz the power, 2016-11-04 23:19:10]

Patchset 2 (id:??) landed as
https://crrev.com/0eed93bebd58e2ed526edd3c8fbafc442d07b486
Cr-Commit-Position: refs/heads/master@{#430062}