third_party/WebKit/LayoutTests/http/tests/preload/preload-video-cors.html - Issue 2476943002: Ensure video poster preloads use the crossorigin attribute

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/preload/preload-video-cors.html

Issue 2476943002: Ensure video poster preloads use the crossorigin attribute (Closed)

Patch Set: Remove empty script block (trybots previous) Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../resources/testharness.js"></script>

	3 <script src="../resources/testharnessreport.js"></script>

	4 <script>

	5 var t = async_test("Ensure preloads use video poster crossorigin value");

	6 window.addEventListener('load', t.step_func(function() {

	7 var entries = performance.getEntriesByName("http://localhost:8080/security /resources/image-access-control.php?file=../../resources/square100.png&allow=fal se");

	8 assert_equals(entries.length, 0);
	Yoav Weiss 2016/11/04 16:07:37 Not sure I get what this test is checking. Not sure I get what this test is checking. Charlie Harrison 2016/11/04 16:11:32 I was trying to check that we never successfully d Show quoted text On 2016/11/04 16:07:37, Yoav Weiss wrote: > Not sure I get what this test is checking. I was trying to check that we never successfully download the resource in a web visible way. I'm open to better ways of doing this though. Yoav Weiss 2016/11/04 16:45:30 OK. Can you also add tests for: * the same crossor Show quoted text On 2016/11/04 16:11:32, Charlie Harrison wrote: > On 2016/11/04 16:07:37, Yoav Weiss wrote: > > Not sure I get what this test is checking. > > I was trying to check that we never successfully download the resource in a web > visible way. I'm open to better ways of doing this though. OK. Can you also add tests for: * the same crossorigin value where the server allows CORS and see that only 1 entry is added (so no double download). * a "no-cors" value where the server disallows CORS and see again only a single entry. <rant> The problem here is that we have no way to test for a double download when the request is expected to fail, but I don't have a good solution for that, other than changing RT to also include entries for CORS failures(not sure this is a valid use case), or creating an internal API that does that. A smarter, stateful server is probably a better way to do that. </rant> Charlie Harrison 2016/11/04 17:20:16 I've added the tests in this file. Your rant is no Show quoted text On 2016/11/04 16:45:30, Yoav Weiss wrote: > On 2016/11/04 16:11:32, Charlie Harrison wrote: > > On 2016/11/04 16:07:37, Yoav Weiss wrote: > > > Not sure I get what this test is checking. > > > > I was trying to check that we never successfully download the resource in a > web > > visible way. I'm open to better ways of doing this though. > > OK. Can you also add tests for: > * the same crossorigin value where the server allows CORS and see that only 1 > entry is added (so no double download). > * a "no-cors" value where the server disallows CORS and see again only a single > entry. > > <rant> > The problem here is that we have no way to test for a double download when the > request is expected to fail, but I don't have a good solution for that, other > than changing RT to also include entries for CORS failures(not sure this is a > valid use case), or creating an internal API that does that. A smarter, stateful > server is probably a better way to do that. </rant> I've added the tests in this file. Your rant is noted :) I'm also not quite sure the best solution here.
	9 t.done();

	10 }));

	11 </script>

	12 <video poster="http://localhost:8080/security/resources/image-access-control.php ?file=../../resources/square100.png&allow=false" crossorigin>

	13 </video>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp » ('j') | no next file with comments »