blimp: Enable the updated compositing path by default.

blimp: Enable the updated compositing path by default.

Set up the engine and client side flags on startup for enabling the mode
by default.

BUG=648442
Committed: https://crrev.com/f8cab90b9d0ffccd136c0d8135444951b7a24f0e
Cr-Commit-Position: refs/heads/master@{#429972}

[Khushal, 2016-11-04 03:48:09]

khushalsagar@chromium.org changed reviewers:
+ dtrainor@chromium.org

[Khushal, 2016-11-04 03:48:10]

\o/

[David Trainor- moved to gerrit, 2016-11-04 04:23:54]

lgtm with nit.

https://codereview.chromium.org/2476873002/diff/1/blimp/client/core/context/b...
File blimp/client/core/context/blimp_client_context_impl.cc (right):

https://codereview.chromium.org/2476873002/diff/1/blimp/client/core/context/b...
blimp/client/core/context/blimp_client_context_impl.cc:143:
base::CommandLine::ForCurrentProcess()->AppendSwitch(
Might be nice to have a function like the one for the engine.  A place where we
can put all blimp-specific command line defaults.

[Khushal, 2016-11-04 04:26:49]

https://codereview.chromium.org/2476873002/diff/1/blimp/client/core/context/b...
File blimp/client/core/context/blimp_client_context_impl.cc (right):

https://codereview.chromium.org/2476873002/diff/1/blimp/client/core/context/b...
blimp/client/core/context/blimp_client_context_impl.cc:143:
base::CommandLine::ForCurrentProcess()->AppendSwitch(
On 2016/11/04 04:23:54, David Trainor wrote:
> Might be nice to have a function like the one for the engine.  A place where
we
> can put all blimp-specific command line defaults.

That's a cool idea. Is there a better place to do this? Otherwise I can put it
in a function here in the .cc file itself.

[David Trainor- moved to gerrit, 2016-11-04 04:31:40]

On 2016/11/04 04:26:49, Khushal wrote:
>
https://codereview.chromium.org/2476873002/diff/1/blimp/client/core/context/b...
> File blimp/client/core/context/blimp_client_context_impl.cc (right):
> 
>
https://codereview.chromium.org/2476873002/diff/1/blimp/client/core/context/b...
> blimp/client/core/context/blimp_client_context_impl.cc:143:
> base::CommandLine::ForCurrentProcess()->AppendSwitch(
> On 2016/11/04 04:23:54, David Trainor wrote:
> > Might be nice to have a function like the one for the engine.  A place where
> we
> > can put all blimp-specific command line defaults.
> 
> That's a cool idea. Is there a better place to do this? Otherwise I can put it
> in a function here in the .cc file itself.

blimp/client/core/settings/blimp_client_config.h/cc?  Or
blimp/client/core/context/blimp_client_config.h/cc?

Or the same file... :)  Either way!

[Khushal, 2016-11-04 19:04:40]

The CQ bit was checked by khushalsagar@chromium.org

[Khushal, 2016-11-04 19:04:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org
Link to the patchset: https://codereview.chromium.org/2476873002/#ps20001
(title: "..")

[commit-bot: I haz the power, 2016-11-04 19:05:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 19:21:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-04 20:00:06]

Description was changed from

==========
blimp: Enable the updated compositing path by default.

Set up the engine and client side flags on startup for enabling the mode
by default.

BUG=648442
==========

to

==========
blimp: Enable the updated compositing path by default.

Set up the engine and client side flags on startup for enabling the mode
by default.

BUG=648442

Committed: https://crrev.com/f8cab90b9d0ffccd136c0d8135444951b7a24f0e
Cr-Commit-Position: refs/heads/master@{#429972}
==========

[commit-bot: I haz the power, 2016-11-04 20:00:07]

Patchset 2 (id:??) landed as
https://crrev.com/f8cab90b9d0ffccd136c0d8135444951b7a24f0e
Cr-Commit-Position: refs/heads/master@{#429972}