Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2476873002: blimp: Enable the updated compositing path by default. (Closed)

Created:
4 years, 1 month ago by Khushal
Modified:
4 years, 1 month ago
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, bgoldman+watch-blimp_chromium.org, steimel+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, perumaal+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, scf+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

blimp: Enable the updated compositing path by default. Set up the engine and client side flags on startup for enabling the mode by default. BUG=648442 Committed: https://crrev.com/f8cab90b9d0ffccd136c0d8135444951b7a24f0e Cr-Commit-Position: refs/heads/master@{#429972}

Patch Set 1 #

Total comments: 2

Patch Set 2 : .. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M blimp/client/core/context/blimp_client_context_impl.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
M blimp/engine/app/blimp_engine_config.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Khushal
\o/
4 years, 1 month ago (2016-11-04 03:48:10 UTC) #2
David Trainor- moved to gerrit
lgtm with nit. https://codereview.chromium.org/2476873002/diff/1/blimp/client/core/context/blimp_client_context_impl.cc File blimp/client/core/context/blimp_client_context_impl.cc (right): https://codereview.chromium.org/2476873002/diff/1/blimp/client/core/context/blimp_client_context_impl.cc#newcode143 blimp/client/core/context/blimp_client_context_impl.cc:143: base::CommandLine::ForCurrentProcess()->AppendSwitch( Might be nice to have ...
4 years, 1 month ago (2016-11-04 04:23:54 UTC) #3
Khushal
https://codereview.chromium.org/2476873002/diff/1/blimp/client/core/context/blimp_client_context_impl.cc File blimp/client/core/context/blimp_client_context_impl.cc (right): https://codereview.chromium.org/2476873002/diff/1/blimp/client/core/context/blimp_client_context_impl.cc#newcode143 blimp/client/core/context/blimp_client_context_impl.cc:143: base::CommandLine::ForCurrentProcess()->AppendSwitch( On 2016/11/04 04:23:54, David Trainor wrote: > Might ...
4 years, 1 month ago (2016-11-04 04:26:49 UTC) #4
David Trainor- moved to gerrit
On 2016/11/04 04:26:49, Khushal wrote: > https://codereview.chromium.org/2476873002/diff/1/blimp/client/core/context/blimp_client_context_impl.cc > File blimp/client/core/context/blimp_client_context_impl.cc (right): > > https://codereview.chromium.org/2476873002/diff/1/blimp/client/core/context/blimp_client_context_impl.cc#newcode143 > ...
4 years, 1 month ago (2016-11-04 04:31:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2476873002/20001
4 years, 1 month ago (2016-11-04 19:05:14 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-04 19:21:51 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 20:00:07 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f8cab90b9d0ffccd136c0d8135444951b7a24f0e
Cr-Commit-Position: refs/heads/master@{#429972}

Powered by Google App Engine
This is Rietveld 408576698