Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.h

Issue 2476813002: Move LayoutObject::m_previousPosition... into a global map in ObjectPaintInvalidator (Closed)
Patch Set: - Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutObject.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.h b/third_party/WebKit/Source/core/layout/LayoutObject.h
index 29ac6d526b4e8523b9eaf7912feb73a242366000..40a9aabdb83add290edbcf3689a45838b7e6fae4 100644
--- a/third_party/WebKit/Source/core/layout/LayoutObject.h
+++ b/third_party/WebKit/Source/core/layout/LayoutObject.h
@@ -1589,17 +1589,6 @@ class CORE_EXPORT LayoutObject : public ImageResourceObserver,
void adjustPreviousPaintInvalidationForScrollIfNeeded(
const DoubleSize& scrollDelta);
- // The previous position of the top-left corner of the object in its previous
- // paint backing.
- const LayoutPoint& previousPositionFromPaintInvalidationBacking() const {
- return m_previousPositionFromPaintInvalidationBacking;
- }
- void setPreviousPositionFromPaintInvalidationBacking(
- const LayoutPoint& positionFromPaintInvalidationBacking) {
- m_previousPositionFromPaintInvalidationBacking =
- positionFromPaintInvalidationBacking;
- }
-
PaintInvalidationReason fullPaintInvalidationReason() const {
return m_bitfields.fullPaintInvalidationReason();
}
@@ -1690,9 +1679,6 @@ class CORE_EXPORT LayoutObject : public ImageResourceObserver,
void setPreviousVisualRect(const LayoutRect& r) {
m_layoutObject.setPreviousVisualRect(r);
}
- void setPreviousPositionFromPaintInvalidationBacking(const LayoutPoint& p) {
- m_layoutObject.setPreviousPositionFromPaintInvalidationBacking(p);
- }
void setPreviousBackgroundObscured(bool b) {
m_layoutObject.setPreviousBackgroundObscured(b);
}
@@ -1932,10 +1918,9 @@ class CORE_EXPORT LayoutObject : public ImageResourceObserver,
}
private:
- // Adjusts a visual rect in the space of |m_previousVisualRect| and
- // |m_previousPositionFromPaintInvalidationBacking| to be in the space of the
- // |paintInvalidationContainer|, if needed. They can be different only if
- // |paintInvalidationContainer| is a composited scroller.
+ // Adjusts a visual rect in the space of |m_previousVisualRect| to be in the
+ // space of the |paintInvalidationContainer|, if needed. They can be different
+ // only if |paintInvalidationContainer| is a composited scroller.
void adjustVisualRectForCompositedScrolling(
LayoutRect&,
const LayoutBoxModelObject& paintInvalidationContainer) const;
@@ -2349,12 +2334,6 @@ class CORE_EXPORT LayoutObject : public ImageResourceObserver,
// account for composited scrolling. See
// adjustVisualRectForCompositedScrolling().
LayoutRect m_previousVisualRect;
-
- // This stores the position in the paint invalidation backing's coordinate.
- // It is used to detect layoutObject shifts that forces a full invalidation.
- // This point does *not* account for composited scrolling. See
- // adjustInvalidationRectForCompositedScrolling().
- LayoutPoint m_previousPositionFromPaintInvalidationBacking;
};
// FIXME: remove this once the layout object lifecycle ASSERTS are no longer

Powered by Google App Engine
This is Rietveld 408576698