Adding a destination platform histogram for UMA.

chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc

Index: chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc
diff --git a/chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc b/chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc
index f49f39f6e5b238741031a5bb3addcbba703ad0c2..1fe42ab1a5678a7f225ca18c794a41b2621798c7 100644
--- a/chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc
+++ b/chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc
@@ -40,10 +40,15 @@ constexpr uint32_t kMinVersionForHandleUrl = 2;
 constexpr uint32_t kMinVersionForRequestUrlHandlerList = 2;
 constexpr uint32_t kMinVersionForAddPreferredPackage = 7;
 
-void RecordUma(ArcNavigationThrottle::CloseReason close_reason) {
+void RecordUma(ArcNavigationThrottle::CloseReason close_reason,
+               ArcNavigationThrottle::Platform platform) {
   UMA_HISTOGRAM_ENUMERATION(
       "Arc.IntentHandlerAction", static_cast<int>(close_reason),
       static_cast<int>(ArcNavigationThrottle::CloseReason::SIZE));
+
+  UMA_HISTOGRAM_ENUMERATION(
+      "Arc.IntentHandlerDestinationPlatform", static_cast<int>(platform),
+      static_cast<int>(ArcNavigationThrottle::Platform::SIZE));

[Ilya Sherman, 2016/11/05 01:39:22]

nit: Are these static casts needed?  I thought I remembered some template magic
landing that made them no longer necessary.

[Ilya Sherman, 2016/11/05 01:39:22]

It looks like you emit this same histogram both here and in
arc_navigation_throttle.cc.  Could you please refactor the code to be shared?

[djacobo_, 2016/11/05 04:24:53]

True, very nice catch. Done.

[djacobo_, 2016/11/05 04:24:53]

didnt work :'( could revisit later.

 }
 
 // Shows the Chrome OS' original external protocol dialog as a fallback.
@@ -271,7 +276,11 @@ void OnIntentPickerClosed(int render_process_host_id,
       break;
     }
   }
-  RecordUma(close_reason);
+
+  ArcNavigationThrottle::Platform platform =
+      ArcNavigationThrottle::GetDestinationPlatform(selected_app_package,
+                                                    close_reason);
+  RecordUma(close_reason, platform);
 }
 
 // Called when ARC returned activity icons for the |handlers|.
@@ -324,8 +333,10 @@ void OnUrlHandlerList(int render_process_host_id,
   GetActionResult result;
   if (HandleUrl(render_process_host_id, routing_id, url, handlers,
                 handlers.size(), &result)) {
-    if (result == GetActionResult::HANDLE_URL_IN_ARC)
-      RecordUma(ArcNavigationThrottle::CloseReason::PREFERRED_ACTIVITY_FOUND);
+    if (result == GetActionResult::HANDLE_URL_IN_ARC) {
+      RecordUma(ArcNavigationThrottle::CloseReason::PREFERRED_ACTIVITY_FOUND,
+                ArcNavigationThrottle::Platform::ARC);
+    }
     return;  // the |url| has been handled.
   }