Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Unified Diff: chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc

Issue 2476783002: Adding a destination platform histogram for UMA. (Closed)
Patch Set: Adding unit tests, removing wrong UMA recording. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc
diff --git a/chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc b/chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc
index f49f39f6e5b238741031a5bb3addcbba703ad0c2..cfcb540d094036ba9f547ec133e2bdf7a6c5d450 100644
--- a/chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc
+++ b/chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc
@@ -40,10 +40,15 @@ constexpr uint32_t kMinVersionForHandleUrl = 2;
constexpr uint32_t kMinVersionForRequestUrlHandlerList = 2;
constexpr uint32_t kMinVersionForAddPreferredPackage = 7;
-void RecordUma(ArcNavigationThrottle::CloseReason close_reason) {
+void RecordUma(ArcNavigationThrottle::CloseReason close_reason,
+ ArcNavigationThrottle::Platform platform) {
UMA_HISTOGRAM_ENUMERATION(
"Arc.IntentHandlerAction", static_cast<int>(close_reason),
static_cast<int>(ArcNavigationThrottle::CloseReason::SIZE));
+
+ UMA_HISTOGRAM_ENUMERATION(
+ "Arc.IntentHandlerDestinationPlatform", static_cast<int>(platform),
+ static_cast<int>(ArcNavigationThrottle::Platform::SIZE));
}
// Shows the Chrome OS' original external protocol dialog as a fallback.
@@ -271,7 +276,11 @@ void OnIntentPickerClosed(int render_process_host_id,
break;
}
}
- RecordUma(close_reason);
+
+ ArcNavigationThrottle::Platform platform =
+ ArcNavigationThrottle::GetDestinationPlatform(selected_app_package,
+ close_reason);
+ RecordUma(close_reason, platform);
}
// Called when ARC returned activity icons for the |handlers|.
@@ -325,7 +334,8 @@ void OnUrlHandlerList(int render_process_host_id,
if (HandleUrl(render_process_host_id, routing_id, url, handlers,
handlers.size(), &result)) {
if (result == GetActionResult::HANDLE_URL_IN_ARC)
Yusuke Sato 2016/11/04 16:18:06 Since the RecordUma() call is multi-line, please u
djacobo_ 2016/11/04 17:43:43 Done.
- RecordUma(ArcNavigationThrottle::CloseReason::PREFERRED_ACTIVITY_FOUND);
+ RecordUma(ArcNavigationThrottle::CloseReason::PREFERRED_ACTIVITY_FOUND,
+ ArcNavigationThrottle::Platform::ARC);
return; // the |url| has been handled.
}

Powered by Google App Engine
This is Rietveld 408576698