Adding a destination platform histogram for UMA.

chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 
 #include "chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle.h"
 #include "components/arc/intent_helper/arc_intent_helper_bridge.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"
@@ skipping 125 matching lines @@
   EXPECT_EQ(
       1u, ArcNavigationThrottle::GetAppIndex(CreateArray(2, 1), package_name));
   EXPECT_EQ(
       0u, ArcNavigationThrottle::GetAppIndex(CreateArray(3, 0), package_name));
   EXPECT_EQ(
       1u, ArcNavigationThrottle::GetAppIndex(CreateArray(3, 1), package_name));
   EXPECT_EQ(
       2u, ArcNavigationThrottle::GetAppIndex(CreateArray(3, 2), package_name));
 }
 
+TEST(ArcNavigationThrottleTest, TestGetDestinationPlatform) {

[Yusuke Sato, 2016/11/04 16:18:06]

Thanks!

[djacobo_, 2016/11/04 17:43:43]

Not a problem :)

+  const std::string chrome_app =
+      ArcIntentHelperBridge::kArcIntentHelperPackageName;
+  const std::string non_chrome_app = "fake_package";
+
+  // When the CloseReason is either ERROR or DIALOG_DEACTIVATED we MUST stay in
+  // Chrome not taking into account the selected_app_package.
+  EXPECT_EQ(ArcNavigationThrottle::Platform::CHROME,
+            ArcNavigationThrottle::GetDestinationPlatform(
+                chrome_app, ArcNavigationThrottle::CloseReason::ERROR));
+  EXPECT_EQ(ArcNavigationThrottle::Platform::CHROME,
+            ArcNavigationThrottle::GetDestinationPlatform(
+                non_chrome_app, ArcNavigationThrottle::CloseReason::ERROR));
+  EXPECT_EQ(ArcNavigationThrottle::Platform::CHROME,

[Yusuke Sato, 2016/11/04 16:18:06]

nit: could you swap L159 & L163? The order (chrome_app, non_chrome_app,
non_chrome_app, chrome_app) looks a bit unusual to me.

[djacobo_, 2016/11/04 17:43:43]

Done.

+            ArcNavigationThrottle::GetDestinationPlatform(
+                non_chrome_app,
+                ArcNavigationThrottle::CloseReason::DIALOG_DEACTIVATED));
+  EXPECT_EQ(
+      ArcNavigationThrottle::Platform::CHROME,
+      ArcNavigationThrottle::GetDestinationPlatform(
+          chrome_app, ArcNavigationThrottle::CloseReason::DIALOG_DEACTIVATED));
+
+  // Under any other CloseReason, stay in Chrome only if the package is Chrome.
+  // Otherwise redirect to ARC.
+  EXPECT_EQ(
+      ArcNavigationThrottle::Platform::CHROME,
+      ArcNavigationThrottle::GetDestinationPlatform(
+          chrome_app, ArcNavigationThrottle::CloseReason::ALWAYS_PRESSED));
+  EXPECT_EQ(
+      ArcNavigationThrottle::Platform::CHROME,
+      ArcNavigationThrottle::GetDestinationPlatform(
+          chrome_app, ArcNavigationThrottle::CloseReason::JUST_ONCE_PRESSED));
+  EXPECT_EQ(ArcNavigationThrottle::Platform::CHROME,
+            ArcNavigationThrottle::GetDestinationPlatform(
+                chrome_app,
+                ArcNavigationThrottle::CloseReason::PREFERRED_ACTIVITY_FOUND));
+
+  // Go to ARC on any other case.
+  EXPECT_EQ(
+      ArcNavigationThrottle::Platform::ARC,
+      ArcNavigationThrottle::GetDestinationPlatform(
+          non_chrome_app, ArcNavigationThrottle::CloseReason::ALWAYS_PRESSED));
+  EXPECT_EQ(ArcNavigationThrottle::Platform::ARC,
+            ArcNavigationThrottle::GetDestinationPlatform(
+                non_chrome_app,
+                ArcNavigationThrottle::CloseReason::JUST_ONCE_PRESSED));
+  EXPECT_EQ(ArcNavigationThrottle::Platform::ARC,
+            ArcNavigationThrottle::GetDestinationPlatform(
+                non_chrome_app,
+                ArcNavigationThrottle::CloseReason::PREFERRED_ACTIVITY_FOUND));
+}
+
 TEST(ArcNavigationThrottleTest, TestIsSwapElementsNeeded) {
   std::pair<size_t, size_t> indices;
   for (size_t i = 1; i <= ArcNavigationThrottle::kMaxAppResults; ++i) {
     // When Chrome is the first element, swap is unnecessary.
     mojo::Array<mojom::IntentHandlerInfoPtr> handlers = CreateArray(i, 0);
     EXPECT_FALSE(ArcNavigationThrottle::IsSwapElementsNeededForTesting(
         handlers, &indices))
         << i;
 
     // When Chrome is within the first |kMaxAppResults| elements, swap is
@@ skipping 33 matching lines @@
   for (size_t i = 0; i <= ArcNavigationThrottle::kMaxAppResults * 2; ++i) {
     // When Chrome does not exist in |handlers|, swap is unnecessary.
     mojo::Array<mojom::IntentHandlerInfoPtr> handlers = CreateArray(i, i);
     EXPECT_FALSE(ArcNavigationThrottle::IsSwapElementsNeededForTesting(
         handlers, &indices))
         << i;
   }
 }
 
 }  // namespace arc