Adding a destination platform histogram for UMA.

chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/logging.h"
@@ skipping 355 matching lines @@
     }
     case CloseReason::INVALID: {
       NOTREACHED();
       return;
     }
   }
 
   UMA_HISTOGRAM_ENUMERATION("Arc.IntentHandlerAction",
                             static_cast<int>(close_reason),
                             static_cast<int>(CloseReason::SIZE));
+
+  Platform platform =
+      GetDestinationPlatform(selected_app_package, close_reason);
+  UMA_HISTOGRAM_ENUMERATION("Arc.IntentHandlerDestinationPlatform",
+                            static_cast<int>(platform),
+                            static_cast<int>(Platform::SIZE));
 }
 
 // static
+ArcNavigationThrottle::Platform ArcNavigationThrottle::GetDestinationPlatform(

[Yusuke Sato, 2016/11/04 00:16:14]

* Would you mind adding some unit tests for this?
* Move to L405 to be consistent with the order in .h?

[djacobo_, 2016/11/04 05:53:50]

Done.

+    const std::string& selected_app_package,
+    CloseReason close_reason) {
+  return (close_reason != CloseReason::ERROR &&
+          close_reason != CloseReason::DIALOG_DEACTIVATED &&
+          !ArcIntentHelperBridge::IsIntentHelperPackage(selected_app_package))
+             ? Platform::ARC
+             : Platform::CHROME;
+}
+
+// static
 size_t ArcNavigationThrottle::GetAppIndex(
     const mojo::Array<mojom::IntentHandlerInfoPtr>& handlers,
     const std::string& selected_app_package) {
   for (size_t i = 0; i < handlers.size(); ++i) {
     if (handlers[i]->package_name == selected_app_package)
       return i;
   }
   return handlers.size();
 }
 
@@ skipping 17 matching lines @@
 }
 
 // static
 bool ArcNavigationThrottle::IsSwapElementsNeededForTesting(
     const mojo::Array<mojom::IntentHandlerInfoPtr>& handlers,
     std::pair<size_t, size_t>* out_indices) {
   return IsSwapElementsNeeded(handlers, out_indices);
 }
 
 }  // namespace arc