[MD settings] get cookie details from site without transfering cookie tree

chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/settings/settings_cookies_view_handler.h"
 
 #include <string>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 40 matching lines @@
 CookiesViewHandler::~CookiesViewHandler() {
 }
 
 void CookiesViewHandler::OnJavascriptAllowed() {
 }
 
 void CookiesViewHandler::OnJavascriptDisallowed() {
 }
 
 void CookiesViewHandler::RegisterMessages() {
-  web_ui()->RegisterMessageCallback("updateCookieSearchResults",
-      base::Bind(&CookiesViewHandler::UpdateSearchResults,
+  EnsureCookiesTreeModelCreated();
+
+  web_ui()->RegisterMessageCallback(
+      "getCookieDetails",
+      base::Bind(&CookiesViewHandler::HandleGetCookieDetails,
                  base::Unretained(this)));
-  web_ui()->RegisterMessageCallback("removeAllCookies",
-      base::Bind(&CookiesViewHandler::RemoveAll,
+  web_ui()->RegisterMessageCallback(
+      "updateCookieSearchResults",
+      base::Bind(&CookiesViewHandler::HandleUpdateSearchResults,
                  base::Unretained(this)));
-  web_ui()->RegisterMessageCallback("removeCookie",
-      base::Bind(&CookiesViewHandler::Remove,
-                 base::Unretained(this)));
-  web_ui()->RegisterMessageCallback("loadCookie",
-      base::Bind(&CookiesViewHandler::LoadChildren,
-                 base::Unretained(this)));
-  web_ui()->RegisterMessageCallback("reloadCookies",
-      base::Bind(&CookiesViewHandler::ReloadCookies,
-                 base::Unretained(this)));
+  web_ui()->RegisterMessageCallback(
+      "removeAllCookies",
+      base::Bind(&CookiesViewHandler::HandleRemoveAll, base::Unretained(this)));
+  web_ui()->RegisterMessageCallback(
+      "removeCookie",
+      base::Bind(&CookiesViewHandler::HandleRemove, base::Unretained(this)));
+  web_ui()->RegisterMessageCallback(
+      "loadCookie", base::Bind(&CookiesViewHandler::HandleLoadChildren,
+                               base::Unretained(this)));
+  web_ui()->RegisterMessageCallback(
+      "reloadCookies", base::Bind(&CookiesViewHandler::HandleReloadCookies,
+                                  base::Unretained(this)));
 }
 
 void CookiesViewHandler::TreeNodesAdded(ui::TreeModel* model,
                                         ui::TreeModelNode* parent,
                                         int start,
                                         int count) {
   // Skip if there is a batch update in progress.
   if (batch_update_)
     return;
 
-  AllowJavascript();
-
   CookiesTreeModel* tree_model = static_cast<CookiesTreeModel*>(model);
   CookieTreeNode* parent_node = tree_model->AsNode(parent);
 
   std::unique_ptr<base::ListValue> children(new base::ListValue);
   // Passing false for |include_quota_nodes| since they don't reflect reality
   // until bug http://crbug.com/642955 is fixed and local/session storage is
   // counted against the total.
   model_util_->GetChildNodeList(
       parent_node, start, count, /*include_quota_nodes=*/false, children.get());
 
@@ skipping 10 matching lines @@
 }
 
 void CookiesViewHandler::TreeNodesRemoved(ui::TreeModel* model,
                                           ui::TreeModelNode* parent,
                                           int start,
                                           int count) {
   // Skip if there is a batch update in progress.
   if (batch_update_)
     return;
 
-  AllowJavascript();
-
   CookiesTreeModel* tree_model = static_cast<CookiesTreeModel*>(model);
 
   base::DictionaryValue args;
   if (parent == tree_model->GetRoot())
     args.Set(kId, base::Value::CreateNullValue());
   else
     args.SetString(kId, model_util_->GetTreeNodeId(tree_model->AsNode(parent)));
   args.SetInteger(kStart, start);
   args.SetInteger(kCount, count);
   CallJavascriptFunction("cr.webUIListenerCallback",
                          base::StringValue("onTreeItemRemoved"),
                          args);
 }
 
 void CookiesViewHandler::TreeModelBeginBatch(CookiesTreeModel* model) {
   DCHECK(!batch_update_);  // There should be no nested batch begin.
   batch_update_ = true;
 }
 
 void CookiesViewHandler::TreeModelEndBatch(CookiesTreeModel* model) {
   DCHECK(batch_update_);
   batch_update_ = false;
 
-  SendChildren(model->GetRoot());
+  if (IsJavascriptAllowed())
+    SendChildren(model->GetRoot());
 }
 
 void CookiesViewHandler::EnsureCookiesTreeModelCreated() {
   if (!cookies_tree_model_.get()) {
     Profile* profile = Profile::FromWebUI(web_ui());
     content::StoragePartition* storage_partition =
         content::BrowserContext::GetDefaultStoragePartition(profile);
     content::IndexedDBContext* indexed_db_context =
         storage_partition->GetIndexedDBContext();
     content::ServiceWorkerContext* service_worker_context =
@@ skipping 15 matching lines @@
         new BrowsingDataCacheStorageHelper(cache_storage_context),
         BrowsingDataFlashLSOHelper::Create(profile),
         BrowsingDataMediaLicenseHelper::Create(file_system_context));
     cookies_tree_model_.reset(
         new CookiesTreeModel(container,
                              profile->GetExtensionSpecialStoragePolicy()));
     cookies_tree_model_->AddCookiesTreeObserver(this);
   }
 }
 
-void CookiesViewHandler::UpdateSearchResults(const base::ListValue* args) {
+void CookiesViewHandler::HandleUpdateSearchResults(
+    const base::ListValue* args) {
   base::string16 query;
-  if (!args->GetString(0, &query))
-    return;
-
-  EnsureCookiesTreeModelCreated();
+  CHECK(args->GetString(0, &query));
 
   cookies_tree_model_->UpdateSearchResults(query);
 }
 
-void CookiesViewHandler::RemoveAll(const base::ListValue* args) {
+void CookiesViewHandler::HandleGetCookieDetails(const base::ListValue* args) {
+  CHECK_EQ(2U, args->GetSize());
+  CHECK(args->GetString(0, &callback_id_));
+  std::string site;
+  CHECK(args->GetString(1, &site));
+
+  AllowJavascript();
+  const CookieTreeNode* node = model_util_->GetTreeNodeFromTitle(
+      cookies_tree_model_->GetRoot(), base::UTF8ToUTF16(site));
+
+  if (!node) {
+    RejectJavascriptCallback(base::StringValue(callback_id_),
+                             *base::Value::CreateNullValue());
+    callback_id_.clear();
+    return;
+  }
+
+  SendCookieDetails(node);
+}
+
+void CookiesViewHandler::HandleReloadCookies(const base::ListValue* args) {
   CHECK_EQ(1U, args->GetSize());
   CHECK(args->GetString(0, &callback_id_));
 
+  AllowJavascript();
+  cookies_tree_model_.reset();
   EnsureCookiesTreeModelCreated();
+}
+
+void CookiesViewHandler::HandleRemoveAll(const base::ListValue* args) {
+  CHECK_EQ(1U, args->GetSize());
+  CHECK(args->GetString(0, &callback_id_));
+
   cookies_tree_model_->DeleteAllStoredObjects();
 }
 
-void CookiesViewHandler::Remove(const base::ListValue* args) {
+void CookiesViewHandler::HandleRemove(const base::ListValue* args) {
   std::string node_path;
-  if (!args->GetString(0, &node_path))
-    return;
-
-  EnsureCookiesTreeModelCreated();
+  CHECK(args->GetString(0, &node_path));
 
   const CookieTreeNode* node = model_util_->GetTreeNodeFromPath(
       cookies_tree_model_->GetRoot(), node_path);
   if (node)
     cookies_tree_model_->DeleteCookieNode(const_cast<CookieTreeNode*>(node));
 }
 
-void CookiesViewHandler::LoadChildren(const base::ListValue* args) {
-  CHECK_LT(0U, args->GetSize());
+void CookiesViewHandler::HandleLoadChildren(const base::ListValue* args) {
+  CHECK_EQ(2U, args->GetSize());
   CHECK(args->GetString(0, &callback_id_));
 
   std::string node_path;
-  if (!args->GetString(1, &node_path))
-    return;
-
-  EnsureCookiesTreeModelCreated();
+  CHECK(args->GetString(1, &node_path));
 
   const CookieTreeNode* node = model_util_->GetTreeNodeFromPath(
       cookies_tree_model_->GetRoot(), node_path);
   if (node)
     SendChildren(node);
 }
 
 void CookiesViewHandler::SendChildren(const CookieTreeNode* parent) {
-  AllowJavascript();
-
   std::unique_ptr<base::ListValue> children(new base::ListValue);
   // Passing false for |include_quota_nodes| since they don't reflect reality
   // until bug http://crbug.com/642955 is fixed and local/session storage is
   // counted against the total.
   model_util_->GetChildNodeList(parent, /*start=*/0, parent->child_count(),
       /*include_quota_nodes=*/false, children.get());
 
   base::DictionaryValue args;
   if (parent == cookies_tree_model_->GetRoot())
     args.Set(kId, base::Value::CreateNullValue());
   else
     args.SetString(kId, model_util_->GetTreeNodeId(parent));
   args.Set(kChildren, std::move(children));
 
   ResolveJavascriptCallback(base::StringValue(callback_id_), args);
-  callback_id_ = "";
+  callback_id_.clear();
 }
 
-void CookiesViewHandler::ReloadCookies(const base::ListValue* args) {
-  CHECK_EQ(1U, args->GetSize());
-  CHECK(args->GetString(0, &callback_id_));
+void CookiesViewHandler::SendCookieDetails(const CookieTreeNode* parent) {
+  std::unique_ptr<base::ListValue> children(new base::ListValue);
+  // Passing false for |include_quota_nodes| since they don't reflect reality
+  // until bug http://crbug.com/642955 is fixed and local/session storage is
+  // counted against the total.
+  model_util_->GetChildNodeDetails(parent, /*start=*/0, parent->child_count(),
+                                   /*include_quota_nodes=*/false,
+                                   children.get());
 
-  cookies_tree_model_.reset();
+  base::DictionaryValue args;
+  if (parent == cookies_tree_model_->GetRoot())
+    args.Set(kId, base::Value::CreateNullValue());
+  else
+    args.SetString(kId, model_util_->GetTreeNodeId(parent));
+  args.Set(kChildren, std::move(children));
 
-  EnsureCookiesTreeModelCreated();
+  ResolveJavascriptCallback(base::StringValue(callback_id_), args);
+  callback_id_.clear();
 }
 
 }  // namespace settings