Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2476733002: Blacklist nacl_message_scanner for UBSan. (Closed)

Created:
4 years, 1 month ago by krasin1
Modified:
4 years, 1 month ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Blacklist nacl_message_scanner for UBSan. The code is doing unsafe (and potentially wrong, if the compiler comes to the play) casts, which UBSan and CFI are not happy about. CFI already has this file blacklisted, it's now the time for UBSan to join the party. BUG=520760, 607996 Committed: https://crrev.com/7bacd498506b1089ec53cddf76152baa4840bc24 Cr-Commit-Position: refs/heads/master@{#429696}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M tools/ubsan/vptr_blacklist.txt View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
krasin1
4 years, 1 month ago (2016-11-03 20:55:48 UTC) #2
Dirk Pranke
lgtm, except I think you want your CL description to say "now the time", not ...
4 years, 1 month ago (2016-11-03 21:00:29 UTC) #3
krasin1
On 2016/11/03 21:00:29, Dirk Pranke wrote: > lgtm, except I think you want your CL ...
4 years, 1 month ago (2016-11-03 21:02:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2476733002/1
4 years, 1 month ago (2016-11-03 21:03:30 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 21:13:19 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 21:15:33 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7bacd498506b1089ec53cddf76152baa4840bc24
Cr-Commit-Position: refs/heads/master@{#429696}

Powered by Google App Engine
This is Rietveld 408576698