Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 247673005: Remove the acceleratedCompositingForPluginsEnabled Setting. (Closed)

Created:
6 years, 8 months ago by danakj
Modified:
6 years, 7 months ago
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, abarth-chromium, jchaffraix+rendering, pdr., ojan, rune+blink, piman
Visibility:
Public.

Description

Remove the acceleratedCompositingForPluginsEnabled Setting. It's no longer set to be anything but true. Depends on: https://codereview.chromium.org/239973005/ R=abarth@chromium.org, vollick@chromium.org BUG=365853 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173002

Patch Set 1 #

Patch Set 2 : rm-acceleratedCompositingForPluginsEnabled: #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M Source/core/frame/Settings.in View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderEmbeddedObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/CompositingReasonFinder.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/compositing/CompositingTriggers.h View 1 chunk +0 lines, -1 line 1 comment Download
M Source/web/WebSettingsImpl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebSettingsImpl.cpp View 1 1 chunk +0 lines, -5 lines 0 comments Download
M public/web/WebSettings.h View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
danakj
6 years, 8 months ago (2014-04-22 22:15:47 UTC) #1
ojan
LGTM!
6 years, 8 months ago (2014-04-23 00:25:29 UTC) #2
danakj
abarth PTAL at public/
6 years, 8 months ago (2014-04-23 13:58:11 UTC) #3
Ian Vollick
lgtm + nit. https://codereview.chromium.org/247673005/diff/20001/Source/core/rendering/compositing/CompositingTriggers.h File Source/core/rendering/compositing/CompositingTriggers.h (right): https://codereview.chromium.org/247673005/diff/20001/Source/core/rendering/compositing/CompositingTriggers.h#newcode29 Source/core/rendering/compositing/CompositingTriggers.h:29: VideoTrigger = 1 << 1, can ...
6 years, 8 months ago (2014-04-23 14:51:47 UTC) #4
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 7 months ago (2014-04-30 15:05:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/247673005/20001
6 years, 7 months ago (2014-04-30 15:06:10 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 15:15:08 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink
6 years, 7 months ago (2014-04-30 15:15:08 UTC) #8
danakj
abarth: PTAL at public/
6 years, 7 months ago (2014-04-30 15:15:37 UTC) #9
abarth-chromium
lgtm
6 years, 7 months ago (2014-04-30 16:57:51 UTC) #10
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 7 months ago (2014-04-30 16:59:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/247673005/20001
6 years, 7 months ago (2014-04-30 16:59:50 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 17:09:42 UTC) #13
Message was sent while issue was closed. 
Change committed as 173002

Powered by Google App Engine
This is Rietveld 408576698