Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2476723002: headless: Register event handlers on demand (Closed)

Created:
4 years, 1 month ago by Sami
Modified:
4 years, 1 month ago
Reviewers:
altimin
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

headless: Register event handlers on demand Change the DevTools C++ bindings to only register event handlers when the user adds an observer for the events. This allows dead code elimination to cut about 176 KiB from the Headless Shell application. BUG=612904 Committed: https://crrev.com/1e5ba5ad472920050c6abae57cc43225bdb5ce1b Cr-Commit-Position: refs/heads/master@{#429857}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -9 lines) Patch
M headless/lib/browser/domain_cc.template View 3 chunks +15 lines, -9 lines 0 comments Download
M headless/lib/browser/domain_h.template View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Sami
4 years, 1 month ago (2016-11-03 18:50:46 UTC) #3
altimin
lgtm, thanks!
4 years, 1 month ago (2016-11-04 11:10:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2476723002/1
4 years, 1 month ago (2016-11-04 11:12:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 11:22:20 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 11:24:26 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e5ba5ad472920050c6abae57cc43225bdb5ce1b
Cr-Commit-Position: refs/heads/master@{#429857}

Powered by Google App Engine
This is Rietveld 408576698