Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2476713002: Fix kMediumQuality invMatrix setup for sizes == mip levels (Closed)

Created:
4 years, 1 month ago by f(malita)
Modified:
4 years, 1 month ago
Reviewers:
herb_g, reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix kMediumQuality invMatrix setup for sizes == mip levels When downscaling with kMediumQuality in non-clamp mode, if we happen to hit a size == mip level, then SkBitmapProcInfo::init takes the trivial matrix path and doesn't set up a matrix for normalized coords on the assumption that we're going to ignore the transform. But kMediumQuality disables allow_ignore_fractional_translate, so we take the filter path after all - but with an incorrect matrix. R=reed@google.com BUG=chromium:661180 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2476713002 Committed: https://skia.googlesource.com/skia/+/b1c7f88df9ec40b4efb52d314304adfbaf95697c

Patch Set 1 #

Patch Set 2 : GM #

Patch Set 3 : tweak comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -15 lines) Patch
M gm/bmpfilterqualityrepeat.cpp View 1 2 chunks +25 lines, -14 lines 0 comments Download
M src/core/SkBitmapProcState.cpp View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 20 (14 generated)
f(malita)
This is going to make Boole cringe. The alternative is to defer the allow_ignore_fractional_translate logic ...
4 years, 1 month ago (2016-11-03 17:13:41 UTC) #2
f(malita)
I'll also add a test before landing.
4 years, 1 month ago (2016-11-03 17:18:08 UTC) #6
f(malita)
On 2016/11/03 17:18:08, f(malita) wrote: > I'll also add a test before landing. Test added, ...
4 years, 1 month ago (2016-11-03 18:14:02 UTC) #14
reed1
lgtm
4 years, 1 month ago (2016-11-03 18:35:40 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2476713002/40001
4 years, 1 month ago (2016-11-03 18:37:25 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 18:42:54 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/b1c7f88df9ec40b4efb52d314304adfbaf95697c

Powered by Google App Engine
This is Rietveld 408576698