Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2476683002: Rename //mojo/public:bindings -> mojo:bindings_java (Closed)

Created:
4 years, 1 month ago by agrieve
Modified:
4 years, 1 month ago
Reviewers:
brettw, yzshen1
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, Peter Beverloo, jam, timvolodine, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, yzshen+watch_chromium.org, agrieve+watch_chromium.org, darin (slow to review), jochen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename //mojo/public/java:bindings -> :bindings_java and //mojo/public/java:system -> :system_java This removes a naming exception from the android java targets whitelist within internal_rules.gni. BUG=620034 Committed: https://crrev.com/ed37c92f79b0cfa854cb3a9b1a02a6c89e4699c2 Cr-Commit-Position: refs/heads/master@{#429941}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -29 lines) Patch
M build/config/android/internal_rules.gni View 1 chunk +0 lines, -1 line 2 comments Download
M chrome/android/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
M content/public/android/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
M content/shell/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M device/battery/android/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M device/nfc/android/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M device/vibration/android/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/android/BUILD.gn View 3 chunks +4 lines, -4 lines 0 comments Download
M mojo/public/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/java/BUILD.gn View 3 chunks +10 lines, -3 lines 0 comments Download
M mojo/public/tools/bindings/mojom.gni View 1 chunk +2 lines, -2 lines 0 comments Download
M services/service_manager/public/java/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
agrieve
yzshen@chromium.org: Please review for rename brettw@chromium.org: for root owners
4 years, 1 month ago (2016-11-03 15:12:18 UTC) #3
yzshen1
lgtm
4 years, 1 month ago (2016-11-03 15:50:47 UTC) #4
brettw
https://codereview.chromium.org/2476683002/diff/1/build/config/android/internal_rules.gni File build/config/android/internal_rules.gni (left): https://codereview.chromium.org/2476683002/diff/1/build/config/android/internal_rules.gni#oldcode42 build/config/android/internal_rules.gni:42: "//mojo/public/java:bindings", Did you also mean to remove bindings? It ...
4 years, 1 month ago (2016-11-03 19:46:27 UTC) #5
agrieve
https://codereview.chromium.org/2476683002/diff/1/build/config/android/internal_rules.gni File build/config/android/internal_rules.gni (left): https://codereview.chromium.org/2476683002/diff/1/build/config/android/internal_rules.gni#oldcode42 build/config/android/internal_rules.gni:42: "//mojo/public/java:bindings", On 2016/11/03 19:46:27, brettw (ping on IM after ...
4 years, 1 month ago (2016-11-03 20:03:00 UTC) #6
brettw
okay, lgtm
4 years, 1 month ago (2016-11-03 20:08:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2476683002/1
4 years, 1 month ago (2016-11-03 20:09:49 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/310573)
4 years, 1 month ago (2016-11-03 22:08:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2476683002/1
4 years, 1 month ago (2016-11-04 16:46:52 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 17:43:31 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 17:47:35 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed37c92f79b0cfa854cb3a9b1a02a6c89e4699c2
Cr-Commit-Position: refs/heads/master@{#429941}

Powered by Google App Engine
This is Rietveld 408576698