wptserve: Import the latest revision of wptserve-related files.

wptserve: Import the latest revision of wptserve-related files.

This revision contains fixes for the 'alias' feature.

* Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/six/
  New third-party code. WPTServe depends on it.

* Tools/Scripts/webkitpy/thirdparty/wpt/checkout.sh
  - Show the HEAD revision.  It is helpful if WPTHeads contains "master"s to
    check out.
  - Add a workaround of a bug of xargs on macOS.

This CL doesn't affect production, and doesn't affect main layout test bots.

BUG=627008
Committed: https://crrev.com/b4c1192626a5d180457403d2c97ebf5232ddfb81
Committed: https://crrev.com/e6af5663ca3c637cc6b0ff9577fc53862d24bf5e
Cr-Original-Commit-Position: refs/heads/master@{#429733}
Cr-Commit-Position: refs/heads/master@{#430172}

[tkent, 2016-11-03 13:26:07]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 13:26:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-11-03 13:27:41]

tkent@chromium.org changed reviewers:
+ jsbell@chromium.org, qyearsley@chromium.org

[tkent, 2016-11-03 13:27:42]

jsbell@ or qyearsley@, would you review this please?
This is the second try for "alias" feature.  It must work well after this CL.

[commit-bot: I haz the power, 2016-11-03 14:28:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 14:28:08]

Dry run: This issue passed the CQ dry run.

[jsbell, 2016-11-03 16:19:40]

lgtm...

https://codereview.chromium.org/2476653002/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/checkout.sh
(right):

https://codereview.chromium.org/2476653002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/checkout.sh:38: # xargs
on macOS.
This is unfortunate... how about using -print0, --null and -0 for find, grep and
xargs respectively, if those are supported?

[qyearsley, 2016-11-03 19:40:24]

On 2016/11/03 at 16:19:40, jsbell wrote:
> lgtm...
> 
>
https://codereview.chromium.org/2476653002/diff/1/third_party/WebKit/Tools/Sc...
> File third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/checkout.sh
(right):
> 
>
https://codereview.chromium.org/2476653002/diff/1/third_party/WebKit/Tools/Sc...
> third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/checkout.sh:38: #
xargs on macOS.
> This is unfortunate... how about using -print0, --null and -0 for find, grep
and xargs respectively, if those are supported?

I agree with jsbell@, lgtm although there might be a nicer way to do it.
Probably not worth spending a lot of time on, but anyway
http://stackoverflow.com/questions/143171/how-can-i-use-xargs-to-copy-files-t...
has some possible suggestions.

[tkent, 2016-11-03 23:22:45]

On 2016/11/03 at 19:40:24, qyearsley wrote:
> On 2016/11/03 at 16:19:40, jsbell wrote:
> > lgtm...
> > 
> >
https://codereview.chromium.org/2476653002/diff/1/third_party/WebKit/Tools/Sc...
> > File third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/checkout.sh
(right):
> > 
> >
https://codereview.chromium.org/2476653002/diff/1/third_party/WebKit/Tools/Sc...
> > third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/checkout.sh:38: #
xargs on macOS.
> > This is unfortunate... how about using -print0, --null and -0 for find, grep
and xargs respectively, if those are supported?
> 
> I agree with jsbell@, lgtm although there might be a nicer way to do it.
Probably not worth spending a lot of time on, but anyway
http://stackoverflow.com/questions/143171/how-can-i-use-xargs-to-copy-files-t...
has some possible suggestions.

Unfortunately |grep --null| doesn't work because --null is for file names, not
content.

There are some other workarounds:
* find ... | grep ... | sed s/\n/\0/g | xargs -0 ...
* find ... -exec another-script-removing-non-whitelisted-file
* find ... -not -regex whitelist-pattern -exec rm
* Check out WPT on a temporary place, and copy only whitelisted-files

I think the change in Patch Set 1 is simple and easy to understand :)

[tkent, 2016-11-03 23:22:48]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2016-11-03 23:24:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 00:01:16]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-04 00:05:07]

Description was changed from

==========
wptserve: Import the latest revision of wptserve-related files.

This revision contains fixes for the 'alias' feature.

* Tools/Scripts/webkitpy/thirdparty/wpt/checkout.sh
  - Show the HEAD revision.  It is helpful if WPTHeads contains "master"s to
    check out.
  - Add a workaround of a bug of xargs on macOS.

This CL doesn't affect production, and doesn't affect main layout test bots.

BUG=627008
==========

to

==========
wptserve: Import the latest revision of wptserve-related files.

This revision contains fixes for the 'alias' feature.

* Tools/Scripts/webkitpy/thirdparty/wpt/checkout.sh
  - Show the HEAD revision.  It is helpful if WPTHeads contains "master"s to
    check out.
  - Add a workaround of a bug of xargs on macOS.

This CL doesn't affect production, and doesn't affect main layout test bots.

BUG=627008

Committed: https://crrev.com/b4c1192626a5d180457403d2c97ebf5232ddfb81
Cr-Commit-Position: refs/heads/master@{#429733}
==========

[commit-bot: I haz the power, 2016-11-04 00:05:07]

Patchset 1 (id:??) landed as
https://crrev.com/b4c1192626a5d180457403d2c97ebf5232ddfb81
Cr-Commit-Position: refs/heads/master@{#429733}

[qyearsley, 2016-11-04 00:11:27]

On 2016/11/03 at 23:22:45, tkent wrote:
> On 2016/11/03 at 19:40:24, qyearsley wrote:
> > On 2016/11/03 at 16:19:40, jsbell wrote:
> > > lgtm...
> > > 
> > >
https://codereview.chromium.org/2476653002/diff/1/third_party/WebKit/Tools/Sc...
> > > File third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/checkout.sh
(right):
> > > 
> > >
https://codereview.chromium.org/2476653002/diff/1/third_party/WebKit/Tools/Sc...
> > > third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/checkout.sh:38: #
xargs on macOS.
> > > This is unfortunate... how about using -print0, --null and -0 for find,
grep and xargs respectively, if those are supported?
> > 
> > I agree with jsbell@, lgtm although there might be a nicer way to do it.
Probably not worth spending a lot of time on, but anyway
http://stackoverflow.com/questions/143171/how-can-i-use-xargs-to-copy-files-t...
has some possible suggestions.
> 
> Unfortunately |grep --null| doesn't work because --null is for file names, not
content.
> 
> There are some other workarounds:
> * find ... | grep ... | sed s/\n/\0/g | xargs -0 ...
> * find ... -exec another-script-removing-non-whitelisted-file
> * find ... -not -regex whitelist-pattern -exec rm
> * Check out WPT on a temporary place, and copy only whitelisted-files
> 
> I think the change in Patch Set 1 is simple and easy to understand :)

Yeah, that sounds good to me :-)

[tkent, 2016-11-04 07:48:20]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2478073002/ by tkent@chromium.org.

The reason for reverting is: Broke WPTServe bots on Linux and Windows.

[tkent, 2016-11-04 13:59:08]

Description was changed from

==========
wptserve: Import the latest revision of wptserve-related files.

This revision contains fixes for the 'alias' feature.

* Tools/Scripts/webkitpy/thirdparty/wpt/checkout.sh
  - Show the HEAD revision.  It is helpful if WPTHeads contains "master"s to
    check out.
  - Add a workaround of a bug of xargs on macOS.

This CL doesn't affect production, and doesn't affect main layout test bots.

BUG=627008

Committed: https://crrev.com/b4c1192626a5d180457403d2c97ebf5232ddfb81
Cr-Commit-Position: refs/heads/master@{#429733}
==========

to

==========
wptserve: Import the latest revision of wptserve-related files.

This revision contains fixes for the 'alias' feature.

* Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/six/
  New third-party code. WPTServe depends on it.

* Tools/Scripts/webkitpy/thirdparty/wpt/checkout.sh
  - Show the HEAD revision.  It is helpful if WPTHeads contains "master"s to
    check out.
  - Add a workaround of a bug of xargs on macOS.

This CL doesn't affect production, and doesn't affect main layout test bots.

BUG=627008

Committed: https://crrev.com/b4c1192626a5d180457403d2c97ebf5232ddfb81
Cr-Commit-Position: refs/heads/master@{#429733}
==========

[tkent, 2016-11-04 14:03:15]

On 2016/11/04 at 07:48:20, tkent wrote:
> A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2478073002/ by tkent@chromium.org.
> 
> The reason for reverting is: Broke WPTServe bots on Linux and Windows.

I couldn't reproduce the issue on my local Linux box, and the bot didn't have
detailed log.  However, I guess this revision of WPTServe introduced 'six'
dependency and the bot didn't have it.  Patch Set 2 adds 'wpt/tools/six'. 
Please take a look again.
Updated files:
 - thirdparty/README.chromium
 - thirdparty/wpt/WPTHeads
 - thirdparty/wpt/WPTWhiteList
 - thirdparty/wpt/wpt/tools/six/*

[qyearsley, 2016-11-04 16:46:13]

On 2016/11/04 at 14:03:15, tkent wrote:
> On 2016/11/04 at 07:48:20, tkent wrote:
> > A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2478073002/ by tkent@chromium.org.
> > 
> > The reason for reverting is: Broke WPTServe bots on Linux and Windows.
> 
> I couldn't reproduce the issue on my local Linux box, and the bot didn't have
detailed log.  However, I guess this revision of WPTServe introduced 'six'
dependency and the bot didn't have it.  Patch Set 2 adds 'wpt/tools/six'. 
Please take a look again.
> Updated files:
>  - thirdparty/README.chromium
>  - thirdparty/wpt/WPTHeads
>  - thirdparty/wpt/WPTWhiteList
>  - thirdparty/wpt/wpt/tools/six/*

LGTM - is it possible to re-commit with this same CL number? (I thought it was
necessary to re-upload a new CL to reland after revert)

[tkent, 2016-11-05 17:10:37]

On 2016/11/04 at 16:46:13, qyearsley wrote:
> LGTM - is it possible to re-commit with this same CL number? (I thought it was
necessary to re-upload a new CL to reland after revert)

Yes. AFAIK, either way is acceptable.

[tkent, 2016-11-05 17:10:41]

The CQ bit was checked by tkent@chromium.org

[tkent, 2016-11-05 17:10:41]

The patchset sent to the CQ was uploaded after l-g-t-m from jsbell@chromium.org
Link to the patchset: https://codereview.chromium.org/2476653002/#ps20001
(title: "Add six")

[commit-bot: I haz the power, 2016-11-05 17:10:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-05 18:25:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-05 18:27:48]

Description was changed from

==========
wptserve: Import the latest revision of wptserve-related files.

This revision contains fixes for the 'alias' feature.

* Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/six/
  New third-party code. WPTServe depends on it.

* Tools/Scripts/webkitpy/thirdparty/wpt/checkout.sh
  - Show the HEAD revision.  It is helpful if WPTHeads contains "master"s to
    check out.
  - Add a workaround of a bug of xargs on macOS.

This CL doesn't affect production, and doesn't affect main layout test bots.

BUG=627008

Committed: https://crrev.com/b4c1192626a5d180457403d2c97ebf5232ddfb81
Cr-Commit-Position: refs/heads/master@{#429733}
==========

to

==========
wptserve: Import the latest revision of wptserve-related files.

This revision contains fixes for the 'alias' feature.

* Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/six/
  New third-party code. WPTServe depends on it.

* Tools/Scripts/webkitpy/thirdparty/wpt/checkout.sh
  - Show the HEAD revision.  It is helpful if WPTHeads contains "master"s to
    check out.
  - Add a workaround of a bug of xargs on macOS.

This CL doesn't affect production, and doesn't affect main layout test bots.

BUG=627008

Committed: https://crrev.com/b4c1192626a5d180457403d2c97ebf5232ddfb81
Committed: https://crrev.com/e6af5663ca3c637cc6b0ff9577fc53862d24bf5e
Cr-Original-Commit-Position: refs/heads/master@{#429733}
Cr-Commit-Position: refs/heads/master@{#430172}
==========

[commit-bot: I haz the power, 2016-11-05 18:27:49]

Patchset 2 (id:??) landed as
https://crrev.com/e6af5663ca3c637cc6b0ff9577fc53862d24bf5e
Cr-Commit-Position: refs/heads/master@{#430172}