Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2476643003: [wasm] Fix a memory leak in test-run-wasm-module. (Closed)

Created:
4 years, 1 month ago by ahaas
Modified:
4 years, 1 month ago
Reviewers:
titzer, tizer
CC:
v8-reviews_googlegroups.com, Michael Lippautz
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Fix a memory leak in test-run-wasm-module. The memory leak is fixed by calling the GC at the end of the tests. The GC collects the WasmModuleWrapper objects, which deallocates WasmModule c++ object. For the mjsunit tests the GC is already called because of the --invoke_weak_callbacks flag. BUG=chromium:662388 Committed: https://crrev.com/0ab9ecc23ada2a8614afe46b86bcdd8cfc9cbbb4 Cr-Commit-Position: refs/heads/master@{#40822}

Patch Set 1 #

Patch Set 2 : Let the handle scope end so the gc can collect the WasmModule #

Patch Set 3 : fix memory leaks #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+447 lines, -369 lines) Patch
M src/wasm/wasm-module.cc View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-module.cc View 1 2 3 4 chunks +443 lines, -365 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
ahaas
On 2016/11/04 at 14:04:03, ahaas wrote: > ahaas@chromium.org changed reviewers: > + tizer@chromium.org PTAL
4 years, 1 month ago (2016-11-04 14:04:14 UTC) #7
titzer
lgtm
4 years, 1 month ago (2016-11-08 09:57:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2476643003/60001
4 years, 1 month ago (2016-11-08 10:10:17 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-08 10:33:49 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:25:38 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/0ab9ecc23ada2a8614afe46b86bcdd8cfc9cbbb4
Cr-Commit-Position: refs/heads/master@{#40822}

Powered by Google App Engine
This is Rietveld 408576698