Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: tools/gn/ninja_action_target_writer_unittest.cc

Issue 247663006: Add more phony rules to GN build (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tests Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/filesystem_utils_unittest.cc ('k') | tools/gn/ninja_build_writer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_action_target_writer_unittest.cc
diff --git a/tools/gn/ninja_action_target_writer_unittest.cc b/tools/gn/ninja_action_target_writer_unittest.cc
index c1aa6f495b85ff6e845d68d9a102a013e108495c..87903e7e010ee2b135ccd348d5b88ad910a258de 100644
--- a/tools/gn/ninja_action_target_writer_unittest.cc
+++ b/tools/gn/ninja_action_target_writer_unittest.cc
@@ -148,11 +148,11 @@ TEST(NinjaActionTargetWriter, ActionWithSources) {
// depending if we're on actual Windows or Linux pretending to be Windows.
const char expected_win[] =
"rule __foo_bar___rule\n"
- " command = C:/python/python.exe gyp-win-tool action-wrapper environment.x86 __foo_bar___rule.$unique_name.rsp\n"
+ " command = C$:/python/python.exe gyp-win-tool action-wrapper environment.x86 __foo_bar___rule.$unique_name.rsp\n"
" description = ACTION //foo:bar()\n"
" restat = 1\n"
" rspfile = __foo_bar___rule.$unique_name.rsp\n"
- " rspfile_content = C:/python/python.exe ../../foo/script.py\n"
+ " rspfile_content = C$:/python/python.exe ../../foo/script.py\n"
"\n"
"build foo.out: __foo_bar___rule | ../../foo/included.txt ../../foo/source.txt\n"
"\n"
@@ -237,12 +237,12 @@ TEST(NinjaActionTargetWriter, ForEach) {
// depending if we're on actual Windows or Linux pretending to be Windows.
const char expected_win[] =
"rule __foo_bar___rule\n"
- " command = C:/python/python.exe gyp-win-tool action-wrapper "
+ " command = C$:/python/python.exe gyp-win-tool action-wrapper "
"environment.x86 __foo_bar___rule.$unique_name.rsp\n"
" description = ACTION //foo:bar()\n"
" restat = 1\n"
" rspfile = __foo_bar___rule.$unique_name.rsp\n"
- " rspfile_content = C:/python/python.exe ../../foo/script.py -i "
+ " rspfile_content = C$:/python/python.exe ../../foo/script.py -i "
"${source} \"--out=foo$ bar${source_name_part}.o\"\n"
"\n"
"build input1.out: __foo_bar___rule ../../foo/input1.txt | "
@@ -341,12 +341,12 @@ TEST(NinjaActionTargetWriter, ForEachWithDepfile) {
// depending if we're on actual Windows or Linux pretending to be Windows.
const char expected_win[] =
"rule __foo_bar___rule\n"
- " command = C:/python/python.exe gyp-win-tool action-wrapper "
+ " command = C$:/python/python.exe gyp-win-tool action-wrapper "
"environment.x86 __foo_bar___rule.$unique_name.rsp\n"
" description = ACTION //foo:bar()\n"
" restat = 1\n"
" rspfile = __foo_bar___rule.$unique_name.rsp\n"
- " rspfile_content = C:/python/python.exe ../../foo/script.py -i "
+ " rspfile_content = C$:/python/python.exe ../../foo/script.py -i "
"${source} \"--out=foo$ bar${source_name_part}.o\"\n"
"\n"
"build gen/input1.d input1.out: __foo_bar___rule ../../foo/input1.txt"
« no previous file with comments | « tools/gn/filesystem_utils_unittest.cc ('k') | tools/gn/ninja_build_writer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698