Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn/escape.cc

Issue 247663006: Add more phony rules to GN build (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gn/filesystem_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/escape.cc
diff --git a/tools/gn/escape.cc b/tools/gn/escape.cc
index e10e24a2b68c48f6a5c0454e33ecd036879320e0..c1acc722a9f036a383aa1052c373e2650d4aae5e 100644
--- a/tools/gn/escape.cc
+++ b/tools/gn/escape.cc
@@ -58,6 +58,9 @@ void EscapeStringToString(const base::StringPiece& str,
} else if (str[i] == '\\' && (options.mode & ESCAPE_JSON)) {
dest->push_back('\\');
dest->push_back('\\');
+ } else if (str[i] == ':' && (options.mode & ESCAPE_NINJA)) {
+ dest->push_back('$');
+ dest->push_back(':');
scottmg 2014/04/28 19:50:53 test for this
} else {
dest->push_back(str[i]);
}
« no previous file with comments | « no previous file | tools/gn/filesystem_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698