Date and Time dialog for when the clock isn't synced.

chrome/browser/ui/webui/chromeos/set_time_ui.cc

Index: chrome/browser/ui/webui/chromeos/set_time_ui.cc
diff --git a/chrome/browser/ui/webui/chromeos/set_time_ui.cc b/chrome/browser/ui/webui/chromeos/set_time_ui.cc
new file mode 100644
index 0000000000000000000000000000000000000000..fabc420b07ed610e212343991892585e7f52c47f
--- /dev/null
+++ b/chrome/browser/ui/webui/chromeos/set_time_ui.cc
@@ -0,0 +1,137 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/webui/chromeos/set_time_ui.h"
+
+#include "ash/shell.h"
+#include "ash/system/tray/system_tray_delegate.h"
+#include "ash/system/user/login_status.h"
+#include "base/bind.h"
+#include "base/bind_helpers.h"
+#include "base/build_time.h"
+#include "base/values.h"
+#include "chrome/browser/chromeos/settings/cros_settings.h"
+#include "chrome/browser/chromeos/system/timezone_util.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/common/url_constants.h"
+#include "chromeos/dbus/dbus_thread_manager.h"
+#include "chromeos/dbus/system_clock_client.h"
+#include "chromeos/settings/timezone_settings.h"
+#include "content/public/browser/web_ui.h"
+#include "content/public/browser/web_ui_data_source.h"
+#include "content/public/browser/web_ui_message_handler.h"
+#include "grit/browser_resources.h"
+#include "grit/generated_resources.h"
+
+namespace chromeos {
+
+namespace {
+
+class SetTimeMessageHandler : public content::WebUIMessageHandler,
+                              public system::TimezoneSettings::Observer {
+ public:
+  SetTimeMessageHandler();
+  virtual ~SetTimeMessageHandler();
+
+  // WebUIMessageHandler:
+  virtual void RegisterMessages() OVERRIDE;
+
+ private:
+  // system::TimezoneSettings::Observer:
+  virtual void TimezoneChanged(const icu::TimeZone& timezone) OVERRIDE;
+  void OnSetTime(const base::ListValue* args);
+  void OnSetTimezone(const base::ListValue* args);
+
+  DISALLOW_COPY_AND_ASSIGN(SetTimeMessageHandler);
+};
+
+SetTimeMessageHandler::SetTimeMessageHandler() {
+  system::TimezoneSettings::GetInstance()->AddObserver(this);
+}
+
+SetTimeMessageHandler::~SetTimeMessageHandler() {
+  system::TimezoneSettings::GetInstance()->RemoveObserver(this);
+}
+
+void SetTimeMessageHandler::RegisterMessages() {
+  web_ui()->RegisterMessageCallback(
+      "setTimeInSeconds",
+      base::Bind(&SetTimeMessageHandler::OnSetTime,
+                 base::Unretained(this)));
+  web_ui()->RegisterMessageCallback(
+      "setTimezone",
+      base::Bind(&SetTimeMessageHandler::OnSetTimezone,
+                 base::Unretained(this)));
+}
+
+void SetTimeMessageHandler::OnSetTime(const base::ListValue* args) {
+  int seconds;
+  if (!args->GetInteger(0, &seconds))
+    NOTREACHED();
+
+  chromeos::DBusThreadManager::Get()->GetSystemClockClient()->SetTime(seconds);
+}
+
+void SetTimeMessageHandler::OnSetTimezone(const base::ListValue* args) {
+  std::string timezone_id;
+  if (!args->GetString(0, &timezone_id))
+    NOTREACHED();
+
+  CrosSettings::Get()->SetString(kSystemTimezone, timezone_id);
+}
+
+void SetTimeMessageHandler::TimezoneChanged(const icu::TimeZone& timezone) {

[Nikita (slow), 2014/04/24 14:31:53]

Do you need the same one OnTimeChanged()?

[michaelpg, 2014/04/24 18:52:32]

Hmm, sure. It's a bit weird because if the time changes (for reasons other than
the dialog setting the time) that most likely means the time has synced, in
which case the dialog is no longer necessary. But the behavior in that case is
to just to leave the dialog open, whatever time the user sets won't be applied
and the dialog won't be accessible after that.

So in short, yes there's no harm in updating the dialog's time when the time
changes.

+  base::StringValue timezone_id(
+      system::TimezoneSettings::GetTimezoneID(timezone));
+  web_ui()->CallJavascriptFunction(
+      "settime.TimeSetter.setTimezone", timezone_id);
+}
+
+}  // namespace
+
+SetTimeUI::SetTimeUI(content::WebUI* web_ui) : WebDialogUI(web_ui) {
+  web_ui->AddMessageHandler(new SetTimeMessageHandler());
+
+  // Set up the chrome://set-time source.
+  content::WebUIDataSource* source =
+      content::WebUIDataSource::Create(chrome::kChromeUISetTimeHost);
+  source->SetUseJsonJSFormatV2();
+
+  source->AddLocalizedString("setTimeTitle", IDS_SET_TIME_TITLE);
+  source->AddLocalizedString("prompt", IDS_SET_TIME_PROMPT);
+  source->AddLocalizedString("doneButton", IDS_SET_TIME_BUTTON_CLOSE);
+  source->AddLocalizedString("timezone",
+                             IDS_OPTIONS_SETTINGS_TIMEZONE_DESCRIPTION);
+
+  base::DictionaryValue values;
+  values.Set("timezoneList", chromeos::system::GetTimezoneList().release());
+
+  // If we are logged in, the dialog was launched from the settings page.
+  // Don't show the timezone dropdown in that case.
+  std::string current_timezone_id;
+  ash::user::LoginStatus login_status =
+      ash::Shell::GetInstance()->system_tray_delegate()->GetUserLoginStatus();
+  if (login_status == ash::user::LOGGED_IN_LOCKED ||

[Nikita (slow), 2014/04/24 14:31:53]

Will this dialog be available from lock screen?
I don't think that's necessary.

[stevenjb, 2014/04/24 17:06:23]

The logic and the comment above are inverted which is confusing; it took me a
bit to parse this. Also, I think !LoginState::Get()->IsUserLoggedIn() is better
/ more clear here, per Nikita's comment.

[michaelpg, 2014/04/24 18:52:32]

I didn't realize the Settings button isn't available on the lock screen. I'll
leave this dialog out of the lock screen and set the tray date item as
non-actionable.

[Nikita (slow), 2014/04/25 17:06:18]

Do you still need LOGGED_IN_LOCKED here?

[michaelpg, 2014/04/25 20:05:14]

No, it is being removed.

+      login_status == ash::user::LOGGED_IN_NONE) {
+    CrosSettings::Get()->GetString(kSystemTimezone, &current_timezone_id);
+  }
+  values.SetString("currentTimezoneId", current_timezone_id);
+
+  base::Time build_time = base::GetBuildTime();
+  values.SetDouble("buildTime", build_time.ToJsTime());
+
+  source->AddLocalizedStrings(values);
+  source->SetJsonPath("strings.js");
+
+  source->AddResourcePath("set_time.css", IDR_SET_TIME_CSS);
+  source->AddResourcePath("set_time.js", IDR_SET_TIME_JS);
+  source->SetDefaultResource(IDR_SET_TIME_HTML);
+
+  content::WebUIDataSource::Add(Profile::FromWebUI(web_ui), source);
+}
+
+SetTimeUI::~SetTimeUI() {
+}
+
+}  // namespace chromeos