Date and Time dialog for when the clock isn't synced.

chrome/browser/resources/options/browser_options.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var OptionsPage = options.OptionsPage;
   var ArrayDataModel = cr.ui.ArrayDataModel;
   var RepeatingButton = cr.ui.RepeatingButton;
   var HotwordSearchSettingIndicator = options.HotwordSearchSettingIndicator;
 
@@ skipping 277 matching lines @@
           chrome.send('coreOptionsUserMetricsAction', ['Import_ShowDlg']);
         };
 
         if ($('themes-native-button')) {
           $('themes-native-button').onclick = function(event) {
             chrome.send('themesSetNative');
           };
         }
       }
 
+      // Date and time section (CrOS only).
+      if (cr.isChromeOS) {

[Dan Beam, 2014/04/23 17:51:45]

nit:

  if ($('set-time-button'))

just like themes-native-button above

[michaelpg, 2014/04/24 01:32:23]

get rid of the isChromeOS check? or just add this as well?

themes-native-button is wrapped in an if (cr.isChromeOS) {} else {...}. 

[Dan Beam, 2014/04/24 21:32:23]

get right of the isChromeOS check, full code would be:

  if ($('set-time-button'))
    $('set-time-button').onclick = this.handleSetTime_.bind(this);
wrap the HTML in a:

<if expr="chromeos">
      <!-- set time section -->
</if>

which is basically an #if defined(OS_CHROMEOS) for HTML

[michaelpg, 2014/04/24 22:42:47]

OK, we'll do it that way (the HTML already is wrapped in that if tag)

+        $('set-time-button').onclick = this.handleSetTime_.bind(this);
+      }

[Dan Beam, 2014/04/23 17:51:45]

nit: no curlies

[michaelpg, 2014/04/24 01:32:23]

based on this comment I guess you mean "get rid of the isChromeOS check".

[Dan Beam, 2014/04/24 21:32:23]

right

[michaelpg, 2014/04/24 22:42:47]

Done.

+
       // Default browser section.
       if (!cr.isChromeOS) {
         if (!loadTimeData.getBoolean('showSetDefault')) {
           $('set-default-browser-section').hidden = true;
         }
         $('set-as-default-browser').onclick = function(event) {
           chrome.send('becomeDefaultBrowser');
         };
 
         $('auto-launch').onclick = this.handleAutoLaunchChanged_;
@@ skipping 1412 matching lines @@
     /**
      * Shows (or not) the "User" section of the settings page based on whether
      * any of the sub-sections are present (or not).
      * @private
      */
     maybeShowUserSection_: function() {
       $('sync-users-section').hidden =
           $('profiles-section').hidden &&
           $('sync-section').hidden &&
           $('profiles-supervised-dashboard-tip').hidden;
+    },
+
+    /**
+     * Updates the date and time section with time sync information.
+     * @param {bool} canSetTime Whether the system time can be set.

[Dan Beam, 2014/04/23 17:51:45]

{boolean}

[michaelpg, 2014/04/24 01:32:23]

Done.

+     * @private
+     */
+    canSetTimeChanged_: function(canSetTime) {

[Dan Beam, 2014/04/23 17:51:45]

nit: can* methods sound like they'll return a boolean whether something's
allowed.  updateSetTimeVisibility_ instead (while this method only controls
visibility, at least)?

[michaelpg, 2014/04/24 01:32:23]

How about toggleCanSetTime?

[Dan Beam, 2014/04/24 21:32:23]

I think it's better to set it explicitly one way or another rather than toggle.

[michaelpg, 2014/04/24 22:42:47]

Done.

+      // If the time cannot be set, it has been network-synced.
+      $('time-synced-explanation').hidden = canSetTime;
+      $('set-time').hidden = !canSetTime;
+    },
+
+    /**
+     * Handle the 'set date and time' button click.
+     * @private
+     */
+    handleSetTime_: function() {
+      chrome.send('showSetTime');
     }
+
   };
 
   //Forward public APIs to private implementations.
   [
     'addBluetoothDevice',
+    'canSetTimeChanged',
     'enableCertificateButton',
     'enableFactoryResetSection',
     'getCurrentProfile',
     'getStartStopSyncButton',
     'hideBluetoothSettings',
     'notifyInitializationComplete',
     'removeBluetoothDevice',
     'scrollToSection',
     'setAccountPictureManaged',
     'setWallpaperManaged',
@@ skipping 46 matching lines @@
     BrowserOptions.getLoggedInUsername = function() {
       return BrowserOptions.getInstance().username_;
     };
   }
 
   // Export
   return {
     BrowserOptions: BrowserOptions
   };
 });