chrome/browser/resources/chromeos/set_time.html - Issue 247663003: Date and Time dialog for when the clock isn't synced.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/chromeos/set_time.html

Issue 247663003: Date and Time dialog for when the clock isn't synced. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Set Time Dialog Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/resources/chromeos/set_time.css ('K') | « chrome/browser/resources/chromeos/set_time.css ('k') | chrome/browser/resources/chromeos/set_time.js » ('j') | chrome/browser/resources/chromeos/set_time.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html i18n-values="dir:textdirection;">

	3 <head>

	4 <meta charset="utf-8">

	5 <title i18n-content="setTimeTitle"></title>

	6

	7 <link rel="stylesheet" href="chrome://resources/css/chrome_shared.css">

	8 <link rel="stylesheet" href="set_time.css">

	9

	10 <script src="chrome://resources/js/cr.js"></script>

	11 <script src="chrome://resources/js/load_time_data.js"></script>

	12 <script src="chrome://resources/js/util.js"></script>

	13

	14 <script src="strings.js"></script>

	15 <script src="set_time.js"></script>

	16
	Dan Beam 2014/04/23 17:51:45 nit: I'm not totally sure I understand the organiz nit: I'm not totally sure I understand the organization/point of all these blank lines. if you want to keep the others, I'd at least remove this one ^
	17 </head>

	18

	19 <body i18n-values=".style.fontFamily:fontfamily;.style.fontSize:fontsize">

	20

	21 <div id="set-time">

	22 <h2 i18n-content="setTimeTitle"></h2>

	23 <p id="prompt" i18n-content="prompt" class="row"></p>

	24

	25 <div class="timeControl">

	26 <input type="date" id="date" />
	Dan Beam 2014/04/23 17:51:45 I wouldn't bother with end slashes for self-closin I wouldn't bother with end slashes for self-closing tabs. HTML is fine without them and we're not trying to write XHTML... michaelpg 2014/04/24 01:32:23 Old habits... Show quoted text On 2014/04/23 17:51:45, Dan Beam wrote: > I wouldn't bother with end slashes for self-closing tabs. HTML is fine without > them and we're not trying to write XHTML... Old habits...
	27 <input type="time" id="time" />

	28 </div>

	29

	30 <div id="timezone" class="row" hidden>

	31 <label id="timezone-label" for="timezone-select" i18n-content="timezone">

	32 </label>

	33 <select id="timezone-select" i18n-options="timezoneList">
	Dan Beam 2014/04/23 17:51:45 <select id="timezone-select" i18n-options="timezon <select id="timezone-select" i18n-options="timezoneList"></select> michaelpg 2014/04/24 01:32:23 Done. Show quoted text On 2014/04/23 17:51:45, Dan Beam wrote: > <select id="timezone-select" i18n-options="timezoneList"></select> Done.
	34 </select>

	35 </div>

	36

	37 <div class="button-strip">

	38 <button type="submit" id="done" i18n-content="doneButton"></button>

	39 </div>

	40 </div>

	41

	42 <script src="chrome://resources/js/i18n_template2.js"></script>

	43 </body>

	44 </html>

OLD	NEW