Date and Time dialog for when the clock isn't synced.

chrome/browser/ui/ash/system_tray_delegate_chromeos.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/ash/system_tray_delegate_chromeos.h"
 
 #include <algorithm>
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 49 matching lines @@
 #include "chrome/browser/chromeos/login/login_wizard.h"
 #include "chrome/browser/chromeos/login/supervised_user_manager.h"
 #include "chrome/browser/chromeos/login/user.h"
 #include "chrome/browser/chromeos/login/user_adding_screen.h"
 #include "chrome/browser/chromeos/login/user_manager.h"
 #include "chrome/browser/chromeos/net/network_portal_detector.h"
 #include "chrome/browser/chromeos/options/network_config_view.h"
 #include "chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h"
 #include "chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h"
 #include "chrome/browser/chromeos/profiles/multiprofiles_intro_dialog.h"
+#include "chrome/browser/chromeos/set_time_dialog.h"
 #include "chrome/browser/chromeos/settings/cros_settings.h"
 #include "chrome/browser/chromeos/sim_dialog_delegate.h"
 #include "chrome/browser/chromeos/ui/choose_mobile_network_dialog.h"
 #include "chrome/browser/drive/drive_service_interface.h"
 #include "chrome/browser/feedback/tracing_manager.h"
 #include "chrome/browser/google/google_util.h"
 #include "chrome/browser/lifetime/application_lifetime.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/ui/ash/multi_user/multi_user_util.h"
 #include "chrome/browser/ui/ash/stub_user_accounts_delegate.h"
@@ skipping 387 matching lines @@
 void SystemTrayDelegateChromeOS::ShowSettings() {
   ShowSettingsSubPageForActiveUser("");
 }
 
 bool SystemTrayDelegateChromeOS::ShouldShowSettings() {
   return UserManager::Get()->GetCurrentUserFlow()->ShouldShowSettings();
 }
 
 void SystemTrayDelegateChromeOS::ShowDateSettings() {
   content::RecordAction(base::UserMetricsAction("ShowDateOptions"));
+
+  // Everybody can change the time and time zone (even though they are
+  // device settings).
+  if (GetUserLoginStatus() == ash::user::LOGGED_IN_NONE) {
+    SetTimeDialog::ShowDialog(GetNativeWindow());

[Daniel Erat, 2014/04/24 19:49:59]

this method seems like a strange place to call this. this method is usually used
to display the time zone and 24-hour clock settings page when the user clicks on
the time within the system tray, right?

does the user get to the time-setting dialog through the same route in the UI,
or are there other ways to get to it? if there are other ways, it may be better
to add a new method to the delegate.

also note that you probably want to record separate metrics for the time-setting
path so you can see how frequently it's triggered. right now, i imagine that
those calls would be lumped in with the ShowDateOptions user action reported at
the beginning of this method, which is probably undesirable.

[michaelpg, 2014/04/24 20:37:12]

I've added a separate method and updated DateView to handle multiple action
types.

+    return;
+  }
+
   std::string sub_page =
       std::string(chrome::kSearchSubPage) + "#" +
       l10n_util::GetStringUTF8(IDS_OPTIONS_SETTINGS_SECTION_TITLE_DATETIME);
-  // Everybody can change the time zone (even though it is a device setting).
   ShowSettingsSubPageForActiveUser(sub_page);
 }
 
 void SystemTrayDelegateChromeOS::ShowNetworkSettings(
     const std::string& service_path) {
   if (!LoginState::Get()->IsUserLoggedIn())
     return;
   ShowNetworkSettingsPage(service_path);
 }
 
@@ skipping 920 matching lines @@
     accessibility_subscription_.reset();
   else
     OnAccessibilityModeChanged(details.notify);
 }
 
 ash::SystemTrayDelegate* CreateSystemTrayDelegate() {
   return new SystemTrayDelegateChromeOS();
 }
 
 }  // namespace chromeos