Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 247663002: Trim unit* sections in data/locales/* (Closed)

Created:
6 years, 8 months ago by jungshik at Google
Modified:
6 years, 8 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Visibility:
Public.

Description

Trim unit* sections in data/locales/* Add 'filter_locale_data' function to trim_data.sh Chromium/Blink do not use most of unit* sections in locale data. Keep only duration and compound sub-sections. Update the icudtl.dat and two assembly source files for Mac/Linux. It saves ~200kB (uncompressed). 7z-compressed size reduction is 34kB. With all these changes (up to this CL) applied, the net increase of the ICU data from icu 46 to 52 is 49kB with 7z-compressed. (3,070,246 vs 3,021,457) and ~ 390kB uncompressed (10,370,656 vs 9,980,368 ). BUG=132145 TEST=None. TBR=mark Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265354

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -29785 lines) Patch
M icu52/README.chromium View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M icu52/scripts/trim_data.sh View 1 2 2 chunks +17 lines, -3 lines 0 comments Download
M icu52/source/data/in/icudtl.dat View 1 2 Binary file 0 comments Download
M icu52/source/data/locales/am.txt View 1 2 4 chunks +0 lines, -516 lines 0 comments Download
M icu52/source/data/locales/ar.txt View 1 2 4 chunks +0 lines, -972 lines 0 comments Download
M icu52/source/data/locales/bg.txt View 1 2 4 chunks +0 lines, -516 lines 0 comments Download
M icu52/source/data/locales/bn.txt View 1 2 4 chunks +0 lines, -516 lines 0 comments Download
M icu52/source/data/locales/bn_IN.txt View 1 2 1 chunk +0 lines, -40 lines 0 comments Download
M icu52/source/data/locales/ca.txt View 1 2 4 chunks +0 lines, -508 lines 0 comments Download
M icu52/source/data/locales/cs.txt View 1 2 4 chunks +0 lines, -744 lines 0 comments Download
M icu52/source/data/locales/da.txt View 1 2 4 chunks +0 lines, -516 lines 0 comments Download
M icu52/source/data/locales/de.txt View 1 2 4 chunks +0 lines, -516 lines 0 comments Download
M icu52/source/data/locales/el.txt View 1 2 4 chunks +0 lines, -516 lines 0 comments Download
M icu52/source/data/locales/en.txt View 1 2 4 chunks +0 lines, -508 lines 0 comments Download
M icu52/source/data/locales/en_001.txt View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M icu52/source/data/locales/en_GB.txt View 1 2 1 chunk +0 lines, -90 lines 0 comments Download
M icu52/source/data/locales/es.txt View 1 2 4 chunks +0 lines, -516 lines 0 comments Download
M icu52/source/data/locales/es_MX.txt View 1 2 4 chunks +0 lines, -352 lines 0 comments Download
M icu52/source/data/locales/et.txt View 1 2 4 chunks +0 lines, -516 lines 0 comments Download
M icu52/source/data/locales/fa.txt View 1 2 4 chunks +0 lines, -510 lines 0 comments Download
M icu52/source/data/locales/fi.txt View 1 2 4 chunks +0 lines, -516 lines 0 comments Download
M icu52/source/data/locales/fil.txt View 1 2 4 chunks +0 lines, -516 lines 0 comments Download
M icu52/source/data/locales/fr.txt View 1 2 4 chunks +0 lines, -516 lines 0 comments Download
M icu52/source/data/locales/gsw.txt View 1 2 1 chunk +0 lines, -84 lines 0 comments Download
M icu52/source/data/locales/gu.txt View 1 2 4 chunks +0 lines, -516 lines 0 comments Download
M icu52/source/data/locales/he.txt View 1 2 4 chunks +0 lines, -744 lines 0 comments Download
M icu52/source/data/locales/hi.txt View 1 2 4 chunks +0 lines, -516 lines 0 comments Download
M icu52/source/data/locales/hr.txt View 1 2 4 chunks +0 lines, -630 lines 0 comments Download
M icu52/source/data/locales/hu.txt View 1 2 4 chunks +0 lines, -516 lines 0 comments Download
M icu52/source/data/locales/id.txt View 1 2 4 chunks +0 lines, -402 lines 0 comments Download
M icu52/source/data/locales/it.txt View 1 2 4 chunks +0 lines, -516 lines 0 comments Download
M icu52/source/data/locales/ja.txt View 1 2 4 chunks +0 lines, -402 lines 0 comments Download
M icu52/source/data/locales/kl.txt View 1 2 1 chunk +0 lines, -84 lines 0 comments Download
M icu52/source/data/locales/kn.txt View 1 2 4 chunks +0 lines, -516 lines 0 comments Download
M icu52/source/data/locales/ko.txt View 1 2 4 chunks +0 lines, -402 lines 0 comments Download
M icu52/source/data/locales/lkt.txt View 1 2 3 chunks +0 lines, -57 lines 0 comments Download
M icu52/source/data/locales/lt.txt View 1 2 4 chunks +0 lines, -744 lines 0 comments Download
M icu52/source/data/locales/lv.txt View 1 2 4 chunks +0 lines, -630 lines 0 comments Download
M icu52/source/data/locales/ml.txt View 1 2 4 chunks +0 lines, -512 lines 0 comments Download
M icu52/source/data/locales/mr.txt View 1 2 4 chunks +0 lines, -516 lines 0 comments Download
M icu52/source/data/locales/ms.txt View 1 2 4 chunks +0 lines, -402 lines 0 comments Download
M icu52/source/data/locales/nl.txt View 1 2 4 chunks +0 lines, -516 lines 0 comments Download
M icu52/source/data/locales/pl.txt View 1 2 4 chunks +0 lines, -744 lines 0 comments Download
M icu52/source/data/locales/pt.txt View 1 2 4 chunks +0 lines, -516 lines 0 comments Download
M icu52/source/data/locales/pt_PT.txt View 1 2 4 chunks +0 lines, -516 lines 0 comments Download
M icu52/source/data/locales/reslocal.mk View 1 2 1 chunk +1 line, -1 line 0 comments Download
M icu52/source/data/locales/ro.txt View 1 2 4 chunks +0 lines, -630 lines 0 comments Download
M icu52/source/data/locales/root.txt View 1 2 2 chunks +0 lines, -134 lines 0 comments Download
M icu52/source/data/locales/ru.txt View 1 2 4 chunks +0 lines, -630 lines 0 comments Download
M icu52/source/data/locales/sk.txt View 1 2 4 chunks +0 lines, -744 lines 0 comments Download
M icu52/source/data/locales/sl.txt View 1 2 4 chunks +0 lines, -744 lines 0 comments Download
M icu52/source/data/locales/sr.txt View 1 2 4 chunks +0 lines, -630 lines 0 comments Download
M icu52/source/data/locales/sr_Latn.txt View 1 2 4 chunks +0 lines, -630 lines 0 comments Download
M icu52/source/data/locales/sv.txt View 1 2 4 chunks +0 lines, -516 lines 0 comments Download
M icu52/source/data/locales/sv_FI.txt View 1 2 1 chunk +0 lines, -12 lines 0 comments Download
M icu52/source/data/locales/sw.txt View 1 2 4 chunks +0 lines, -516 lines 0 comments Download
M icu52/source/data/locales/ta.txt View 1 2 4 chunks +0 lines, -516 lines 0 comments Download
M icu52/source/data/locales/te.txt View 1 2 4 chunks +0 lines, -516 lines 0 comments Download
M icu52/source/data/locales/th.txt View 1 2 4 chunks +0 lines, -402 lines 0 comments Download
M icu52/source/data/locales/tr.txt View 1 2 4 chunks +0 lines, -516 lines 0 comments Download
M icu52/source/data/locales/uk.txt View 1 2 4 chunks +0 lines, -744 lines 0 comments Download
M icu52/source/data/locales/uz_Cyrl.txt View 1 2 4 chunks +0 lines, -516 lines 0 comments Download
M icu52/source/data/locales/vi.txt View 1 2 4 chunks +0 lines, -402 lines 0 comments Download
M icu52/source/data/locales/zh.txt View 1 2 4 chunks +0 lines, -402 lines 0 comments Download
M icu52/source/data/locales/zh_Hans_HK.txt View 1 2 1 chunk +0 lines, -64 lines 0 comments Download
M icu52/source/data/locales/zh_Hans_MO.txt View 1 2 1 chunk +0 lines, -64 lines 0 comments Download
M icu52/source/data/locales/zh_Hans_SG.txt View 1 2 1 chunk +0 lines, -64 lines 0 comments Download
M icu52/source/data/locales/zh_Hant.txt View 1 2 4 chunks +0 lines, -402 lines 0 comments Download
M icu52/source/data/locales/zh_Hant_HK.txt View 1 2 1 chunk +0 lines, -99 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jungshik at Google
6 years, 8 months ago (2014-04-22 18:50:11 UTC) #1
jungshik at Google
6 years, 8 months ago (2014-04-22 20:58:59 UTC) #2
Message was sent while issue was closed. 
Committed patchset #3 manually as r265354 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698