Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

Issue 2476573003: [Devtools] Renamed network timeline to "Waterfall" (Closed)
Patch Set: Merge branch 'ADD_WISKERS' into RENAME_TIMELINE_WATERFALL Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 /** 4 /**
5 * @unrestricted 5 * @unrestricted
6 */ 6 */
7 WebInspector.NetworkLogViewColumns = class { 7 WebInspector.NetworkLogViewColumns = class {
8 /** 8 /**
9 * @param {!WebInspector.NetworkLogView} networkLogView 9 * @param {!WebInspector.NetworkLogView} networkLogView
10 * @param {!WebInspector.NetworkTransferTimeCalculator} timeCalculator 10 * @param {!WebInspector.NetworkTransferTimeCalculator} timeCalculator
(...skipping 238 matching lines...) Expand 10 before | Expand all | Expand 10 after
249 if (Runtime.experiments.isEnabled('canvasNetworkTimeline')) 249 if (Runtime.experiments.isEnabled('canvasNetworkTimeline'))
250 this._timelineColumn.setHoveredRequest(request, highlightInitiatorChain); 250 this._timelineColumn.setHoveredRequest(request, highlightInitiatorChain);
251 } 251 }
252 252
253 _createTimelineHeader() { 253 _createTimelineHeader() {
254 this._timelineHeaderElement = this._timelineColumn.contentElement.createChil d('div', 'network-timeline-header'); 254 this._timelineHeaderElement = this._timelineColumn.contentElement.createChil d('div', 'network-timeline-header');
255 this._timelineHeaderElement.addEventListener('click', timelineHeaderClicked. bind(this)); 255 this._timelineHeaderElement.addEventListener('click', timelineHeaderClicked. bind(this));
256 this._timelineHeaderElement.addEventListener( 256 this._timelineHeaderElement.addEventListener(
257 'contextmenu', event => this._innerHeaderContextMenu(new WebInspector.Co ntextMenu(event))); 257 'contextmenu', event => this._innerHeaderContextMenu(new WebInspector.Co ntextMenu(event)));
258 var innerElement = this._timelineHeaderElement.createChild('div'); 258 var innerElement = this._timelineHeaderElement.createChild('div');
259 innerElement.textContent = WebInspector.UIString('Timeline'); 259 innerElement.textContent = WebInspector.UIString('Waterfall');
260 this._timelineColumnSortIcon = this._timelineHeaderElement.createChild('div' , 'sort-order-icon-container') 260 this._timelineColumnSortIcon = this._timelineHeaderElement.createChild('div' , 'sort-order-icon-container')
261 .createChild('div', 'sort-order-icon'); 261 .createChild('div', 'sort-order-icon');
262 262
263 /** 263 /**
264 * @this {WebInspector.NetworkLogViewColumns} 264 * @this {WebInspector.NetworkLogViewColumns}
265 */ 265 */
266 function timelineHeaderClicked() { 266 function timelineHeaderClicked() {
267 var sortOrders = WebInspector.DataGrid.Order; 267 var sortOrders = WebInspector.DataGrid.Order;
268 var sortOrder = 268 var sortOrder =
269 this._dataGrid.sortOrder() === sortOrders.Ascending ? sortOrders.Desce nding : sortOrders.Ascending; 269 this._dataGrid.sortOrder() === sortOrders.Ascending ? sortOrders.Desce nding : sortOrders.Ascending;
(...skipping 240 matching lines...) Expand 10 before | Expand all | Expand 10 after
510 responseSubMenu.appendCheckboxItem( 510 responseSubMenu.appendCheckboxItem(
511 columnConfig.title, this._toggleColumnVisibility.bind(this, columnConf ig), columnConfig.visible); 511 columnConfig.title, this._toggleColumnVisibility.bind(this, columnConf ig), columnConfig.visible);
512 512
513 responseSubMenu.appendSeparator(); 513 responseSubMenu.appendSeparator();
514 responseSubMenu.appendItem( 514 responseSubMenu.appendItem(
515 WebInspector.UIString('Manage Header Columns\u2026'), this._manageCustom HeaderDialog.bind(this)); 515 WebInspector.UIString('Manage Header Columns\u2026'), this._manageCustom HeaderDialog.bind(this));
516 516
517 if (Runtime.experiments.isEnabled('canvasNetworkTimeline')) { 517 if (Runtime.experiments.isEnabled('canvasNetworkTimeline')) {
518 contextMenu.appendSeparator(); 518 contextMenu.appendSeparator();
519 var timelineSortIds = WebInspector.NetworkLogViewColumns.TimelineSortIds; 519 var timelineSortIds = WebInspector.NetworkLogViewColumns.TimelineSortIds;
520 var timelineSubMenu = contextMenu.appendSubMenuItem(WebInspector.UIString( 'Timeline')); 520 var timelineSubMenu = contextMenu.appendSubMenuItem(WebInspector.UIString( 'Waterfall'));
521 timelineSubMenu.appendCheckboxItem( 521 timelineSubMenu.appendCheckboxItem(
522 WebInspector.UIString('Start Time'), setTimelineMode.bind(this, timeli neSortIds.StartTime), 522 WebInspector.UIString('Start Time'), setTimelineMode.bind(this, timeli neSortIds.StartTime),
523 this._activeTimelineSortId === timelineSortIds.StartTime); 523 this._activeTimelineSortId === timelineSortIds.StartTime);
524 timelineSubMenu.appendCheckboxItem( 524 timelineSubMenu.appendCheckboxItem(
525 WebInspector.UIString('Response Time'), setTimelineMode.bind(this, tim elineSortIds.ResponseTime), 525 WebInspector.UIString('Response Time'), setTimelineMode.bind(this, tim elineSortIds.ResponseTime),
526 this._activeTimelineSortId === timelineSortIds.ResponseTime); 526 this._activeTimelineSortId === timelineSortIds.ResponseTime);
527 timelineSubMenu.appendCheckboxItem( 527 timelineSubMenu.appendCheckboxItem(
528 WebInspector.UIString('End Time'), setTimelineMode.bind(this, timeline SortIds.EndTime), 528 WebInspector.UIString('End Time'), setTimelineMode.bind(this, timeline SortIds.EndTime),
529 this._activeTimelineSortId === timelineSortIds.EndTime); 529 this._activeTimelineSortId === timelineSortIds.EndTime);
530 timelineSubMenu.appendCheckboxItem( 530 timelineSubMenu.appendCheckboxItem(
(...skipping 483 matching lines...) Expand 10 before | Expand all | Expand 10 after
1014 {sortingFunction: WebInspector.NetworkDataGridNode.ResponseHeaderStringC omparator.bind(null, 'server')} 1014 {sortingFunction: WebInspector.NetworkDataGridNode.ResponseHeaderStringC omparator.bind(null, 'server')}
1015 }, 1015 },
1016 { 1016 {
1017 id: 'vary', 1017 id: 'vary',
1018 isResponseHeader: true, 1018 isResponseHeader: true,
1019 title: WebInspector.UIString('Vary'), 1019 title: WebInspector.UIString('Vary'),
1020 sortConfig: {sortingFunction: WebInspector.NetworkDataGridNode.ResponseHeade rStringComparator.bind(null, 'vary')} 1020 sortConfig: {sortingFunction: WebInspector.NetworkDataGridNode.ResponseHeade rStringComparator.bind(null, 'vary')}
1021 }, 1021 },
1022 { 1022 {
1023 id: 'timeline', 1023 id: 'timeline',
1024 title: WebInspector.UIString('Timeline'), 1024 title: WebInspector.UIString('Waterfall'),
1025 visible: true, 1025 visible: true,
1026 weight: 40, 1026 weight: 40,
1027 sortable: false, 1027 sortable: false,
1028 hideable: false, 1028 hideable: false,
1029 sortConfig: { 1029 sortConfig: {
1030 entries: [ 1030 entries: [
1031 { 1031 {
1032 id: 'starttime', 1032 id: 'starttime',
1033 title: WebInspector.UIString('Timeline \u2013 Start Time'), 1033 title: WebInspector.UIString('Waterfall \u2013 Start Time'),
1034 sort: WebInspector.DataGrid.Order.Ascending, 1034 sort: WebInspector.DataGrid.Order.Ascending,
1035 sortingFunction: WebInspector.NetworkDataGridNode.RequestPropertyCompa rator.bind(null, 'startTime'), 1035 sortingFunction: WebInspector.NetworkDataGridNode.RequestPropertyCompa rator.bind(null, 'startTime'),
1036 calculator: WebInspector.NetworkLogViewColumns._calculatorTypes.Time 1036 calculator: WebInspector.NetworkLogViewColumns._calculatorTypes.Time
1037 }, 1037 },
1038 { 1038 {
1039 id: 'responsetime', 1039 id: 'responsetime',
1040 title: WebInspector.UIString('Timeline \u2013 Response Time'), 1040 title: WebInspector.UIString('Waterfall \u2013 Response Time'),
1041 sort: WebInspector.DataGrid.Order.Ascending, 1041 sort: WebInspector.DataGrid.Order.Ascending,
1042 sortingFunction: 1042 sortingFunction:
1043 WebInspector.NetworkDataGridNode.RequestPropertyComparator.bind(nu ll, 'responseReceivedTime'), 1043 WebInspector.NetworkDataGridNode.RequestPropertyComparator.bind(nu ll, 'responseReceivedTime'),
1044 calculator: WebInspector.NetworkLogViewColumns._calculatorTypes.Time 1044 calculator: WebInspector.NetworkLogViewColumns._calculatorTypes.Time
1045 }, 1045 },
1046 { 1046 {
1047 id: 'endtime', 1047 id: 'endtime',
1048 title: WebInspector.UIString('Timeline \u2013 End Time'), 1048 title: WebInspector.UIString('Waterfall \u2013 End Time'),
1049 sort: WebInspector.DataGrid.Order.Ascending, 1049 sort: WebInspector.DataGrid.Order.Ascending,
1050 sortingFunction: WebInspector.NetworkDataGridNode.RequestPropertyCompa rator.bind(null, 'endTime'), 1050 sortingFunction: WebInspector.NetworkDataGridNode.RequestPropertyCompa rator.bind(null, 'endTime'),
1051 calculator: WebInspector.NetworkLogViewColumns._calculatorTypes.Time 1051 calculator: WebInspector.NetworkLogViewColumns._calculatorTypes.Time
1052 }, 1052 },
1053 { 1053 {
1054 id: 'duration', 1054 id: 'duration',
1055 title: WebInspector.UIString('Timeline \u2013 Total Duration'), 1055 title: WebInspector.UIString('Waterfall \u2013 Total Duration'),
1056 sort: WebInspector.DataGrid.Order.Descending, 1056 sort: WebInspector.DataGrid.Order.Descending,
1057 sortingFunction: WebInspector.NetworkDataGridNode.RequestPropertyCompa rator.bind(null, 'duration'), 1057 sortingFunction: WebInspector.NetworkDataGridNode.RequestPropertyCompa rator.bind(null, 'duration'),
1058 calculator: WebInspector.NetworkLogViewColumns._calculatorTypes.Durati on 1058 calculator: WebInspector.NetworkLogViewColumns._calculatorTypes.Durati on
1059 }, 1059 },
1060 { 1060 {
1061 id: 'latency', 1061 id: 'latency',
1062 title: WebInspector.UIString('Timeline \u2013 Latency'), 1062 title: WebInspector.UIString('Waterfall \u2013 Latency'),
1063 sort: WebInspector.DataGrid.Order.Descending, 1063 sort: WebInspector.DataGrid.Order.Descending,
1064 sortingFunction: WebInspector.NetworkDataGridNode.RequestPropertyCompa rator.bind(null, 'latency'), 1064 sortingFunction: WebInspector.NetworkDataGridNode.RequestPropertyCompa rator.bind(null, 'latency'),
1065 calculator: WebInspector.NetworkLogViewColumns._calculatorTypes.Durati on 1065 calculator: WebInspector.NetworkLogViewColumns._calculatorTypes.Durati on
1066 } 1066 }
1067 ] 1067 ]
1068 } 1068 }
1069 } 1069 }
1070 ]; 1070 ];
1071 1071
1072 WebInspector.NetworkLogViewColumns._filmStripDividerColor = '#fccc49'; 1072 WebInspector.NetworkLogViewColumns._filmStripDividerColor = '#fccc49';
1073 1073
1074 /** 1074 /**
1075 * @enum {string} 1075 * @enum {string}
1076 */ 1076 */
1077 WebInspector.NetworkLogViewColumns.TimelineSortIds = { 1077 WebInspector.NetworkLogViewColumns.TimelineSortIds = {
1078 StartTime: 'startTime', 1078 StartTime: 'startTime',
1079 ResponseTime: 'responseReceivedTime', 1079 ResponseTime: 'responseReceivedTime',
1080 EndTime: 'endTime', 1080 EndTime: 'endTime',
1081 Duration: 'duration', 1081 Duration: 'duration',
1082 Latency: 'latency' 1082 Latency: 'latency'
1083 }; 1083 };
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698