bluetooth: Fix crash when accepting location permission

bluetooth: Fix crash when accepting location permission

http://crrev.com/2369673003 introduced code to close the chooser when the
window looses focus. This works great for when the user switches apps but
it sadly causes the chooser to get closed when the permission prompt opens
up. Then when the user accepts the permission request chrome crashes
because the chooser was closed.

Checks if the chooser is still opened before restarting the scan.

Changes the testing framework to simulate a focus change when requesting
permission and adds asserts to make sure native functions are not being
called after the native object has been destroyed.

BUG=661770
Committed: https://crrev.com/f7d18c0fc6b044c83e01f169e180835b6c4645da
Cr-Commit-Position: refs/heads/master@{#430197}

[ortuno, 2016-11-03 05:58:29]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 05:58:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ortuno, 2016-11-03 06:03:25]

ortuno@chromium.org changed reviewers:
+ juncai@chromium.org

[ortuno, 2016-11-03 06:03:25]

juncai: PTAL

[commit-bot: I haz the power, 2016-11-03 07:59:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 07:59:19]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[juncai, 2016-11-04 01:21:53]

LGTM with nit.

https://codereview.chromium.org/2476563002/diff/20001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/BluetoothChooserDialogTest.java
(right):

https://codereview.chromium.org/2476563002/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/BluetoothChooserDialogTest.java:67:
assertFalse(mNativeBluetoothChooserDialogPtr == 0);
nit: use assertTrue() here?
same for the following code.

[ortuno, 2016-11-04 03:34:18]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 03:35:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ortuno, 2016-11-04 04:06:03]

Thanks!

https://codereview.chromium.org/2476563002/diff/20001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/BluetoothChooserDialogTest.java
(right):

https://codereview.chromium.org/2476563002/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/BluetoothChooserDialogTest.java:67:
assertFalse(mNativeBluetoothChooserDialogPtr == 0);
On 2016/11/04 at 01:21:53, juncai wrote:
> nit: use assertTrue() here?
> same for the following code.

Done.

[ortuno, 2016-11-04 04:07:05]

ortuno@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[ortuno, 2016-11-04 04:07:05]

dfalcantara: PTAL

[commit-bot: I haz the power, 2016-11-04 04:09:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 04:09:03]

Dry run: This issue passed the CQ dry run.

[gone, 2016-11-04 21:02:31]

lgtm

[ortuno, 2016-11-06 21:56:25]

The CQ bit was checked by ortuno@chromium.org

[ortuno, 2016-11-06 21:56:25]

The patchset sent to the CQ was uploaded after l-g-t-m from juncai@chromium.org
Link to the patchset: https://codereview.chromium.org/2476563002/#ps40001
(title: "Address juncai's comments")

[commit-bot: I haz the power, 2016-11-06 21:56:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-06 22:25:47]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-06 22:28:22]

Description was changed from

==========
bluetooth: Fix crash when accepting location permission

http://crrev.com/2369673003 introduced code to close the chooser when the
window looses focus. This works great for when the user switches apps but
it sadly causes the chooser to get closed when the permission prompt opens
up. Then when the user accepts the permission request chrome crashes
because the chooser was closed.

Checks if the chooser is still opened before restarting the scan.

Changes the testing framework to simulate a focus change when requesting
permission and adds asserts to make sure native functions are not being
called after the native object has been destroyed.

BUG=661770
==========

to

==========
bluetooth: Fix crash when accepting location permission

http://crrev.com/2369673003 introduced code to close the chooser when the
window looses focus. This works great for when the user switches apps but
it sadly causes the chooser to get closed when the permission prompt opens
up. Then when the user accepts the permission request chrome crashes
because the chooser was closed.

Checks if the chooser is still opened before restarting the scan.

Changes the testing framework to simulate a focus change when requesting
permission and adds asserts to make sure native functions are not being
called after the native object has been destroyed.

BUG=661770

Committed: https://crrev.com/f7d18c0fc6b044c83e01f169e180835b6c4645da
Cr-Commit-Position: refs/heads/master@{#430197}
==========

[commit-bot: I haz the power, 2016-11-06 22:28:23]

Patchset 3 (id:??) landed as
https://crrev.com/f7d18c0fc6b044c83e01f169e180835b6c4645da
Cr-Commit-Position: refs/heads/master@{#430197}