Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2357)

Unified Diff: content/renderer/mojo/blink_interface_provider_impl.cc

Issue 2476543003: Create and use BlinkInterfaceProvider WeakPtrs on the same thread (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/mojo/blink_interface_provider_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/mojo/blink_interface_provider_impl.cc
diff --git a/content/renderer/mojo/blink_interface_provider_impl.cc b/content/renderer/mojo/blink_interface_provider_impl.cc
index 0cce6d837d6576d5f6a8066e3baca4bb5dec313c..59e4c50d7e9bc00413800c9f834d4f3d7a94e57b 100644
--- a/content/renderer/mojo/blink_interface_provider_impl.cc
+++ b/content/renderer/mojo/blink_interface_provider_impl.cc
@@ -17,7 +17,9 @@ BlinkInterfaceProviderImpl::BlinkInterfaceProviderImpl(
base::WeakPtr<service_manager::InterfaceProvider> remote_interfaces)
: remote_interfaces_(remote_interfaces),
main_thread_task_runner_(base::ThreadTaskRunnerHandle::Get()),
- weak_ptr_factory_(this) {}
+ weak_ptr_factory_(this) {
+ weak_ptr_ = weak_ptr_factory_.GetWeakPtr();
+}
BlinkInterfaceProviderImpl::~BlinkInterfaceProviderImpl() = default;
@@ -27,8 +29,7 @@ void BlinkInterfaceProviderImpl::getInterface(
if (!main_thread_task_runner_->BelongsToCurrentThread()) {
main_thread_task_runner_->PostTask(
FROM_HERE, base::Bind(&BlinkInterfaceProviderImpl::getInterface,
- weak_ptr_factory_.GetWeakPtr(), name,
- base::Passed(&handle)));
+ weak_ptr_, name, base::Passed(&handle)));
return;
}
« no previous file with comments | « content/renderer/mojo/blink_interface_provider_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698