Android: Remove unnecessary members from WebsiteSettingsPopup

Android: Remove unnecessary members from WebsiteSettingsPopup

These were only used for a check to see if the current page was HTTPS,
which can be done more cleanly by checking the URL. This also fixes an
issue where the 'Details' link was not appearing correctly, due to a
change in the order of member initialization.

BUG=657148
Committed: https://crrev.com/6beda8f1ffcd4476d5304031aa18dfd7f3b7f01a
Cr-Commit-Position: refs/heads/master@{#431399}

[tsergeant, 2016-11-03 04:53:44]

Description was changed from

==========
Android: Delete unnecessary methods in page info popup

BUG=657148
==========

to

==========
Android: Remove unnecessary members from WebsiteSettingsPopup

These were only used for a check to see if the current page was HTTPS,
which can be done more cleanly by checking the URL.

BUG=657148
==========

[tsergeant, 2016-11-10 01:54:41]

Description was changed from

==========
Android: Remove unnecessary members from WebsiteSettingsPopup

These were only used for a check to see if the current page was HTTPS,
which can be done more cleanly by checking the URL.

BUG=657148
==========

to

==========
Android: Remove unnecessary members from WebsiteSettingsPopup

These were only used for a check to see if the current page was HTTPS,
which can be done more cleanly by checking the URL.

BUG=657148
==========

[tsergeant, 2016-11-10 01:55:36]

Description was changed from

==========
Android: Remove unnecessary members from WebsiteSettingsPopup

These were only used for a check to see if the current page was HTTPS,
which can be done more cleanly by checking the URL.

BUG=657148
==========

to

==========
Android: Remove unnecessary members from WebsiteSettingsPopup

These were only used for a check to see if the current page was HTTPS,
which can be done more cleanly by checking the URL. This also fixes an
issue where the 'Details' link was not appearing correctly, due to a
change in the order of member initialization.

BUG=657148
==========

[tsergeant, 2016-11-10 01:56:05]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 01:56:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 02:27:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 02:27:41]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2016-11-10 03:14:19]

tsergeant@chromium.org changed reviewers:
+ meacer@chromium.org, tedchoc@chromium.org

[tsergeant, 2016-11-10 03:14:19]

tedchoc@chromium.org: Please review changes in 
chrome/android

meacer@chromium.org: Please review changes in 
chrome/browser/ssl

Thanks!

[meacer, 2016-11-10 18:41:58]

chrome/browser/ssl LGTM

https://codereview.chromium.org/2476533002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java
(right):

https://codereview.chromium.org/2476533002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java:525:
&& mParsedUrl.getScheme().equals("https");
If mParsedUrl is null from line 386, this will crash, no? Perhaps check
mParsedUrl != null?

[Ted C, 2016-11-10 18:48:42]

lgtm w/ meacer@s null check

https://codereview.chromium.org/2476533002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java
(right):

https://codereview.chromium.org/2476533002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java:525:
&& mParsedUrl.getScheme().equals("https");
On 2016/11/10 18:41:58, Mustafa Emre Acer wrote:
> If mParsedUrl is null from line 386, this will crash, no? Perhaps check
> mParsedUrl != null?

Probably should add mParsedUrl.getScheme() != null to be consistent with the
http/https checks at 396-398

[tsergeant, 2016-11-10 22:35:15]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 22:36:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 23:20:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 23:20:59]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2016-11-10 23:54:37]

Thanks for reviewing!

https://codereview.chromium.org/2476533002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java
(right):

https://codereview.chromium.org/2476533002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java:525:
&& mParsedUrl.getScheme().equals("https");
On 2016/11/10 18:48:42, Ted C wrote:
> On 2016/11/10 18:41:58, Mustafa Emre Acer wrote:
> > If mParsedUrl is null from line 386, this will crash, no? Perhaps check
> > mParsedUrl != null?
> 
> Probably should add mParsedUrl.getScheme() != null to be consistent with the
> http/https checks at 396-398

Done.

[tsergeant, 2016-11-10 23:54:44]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2016-11-10 23:54:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, meacer@chromium.org
Link to the patchset: https://codereview.chromium.org/2476533002/#ps60001
(title: "Null check")

[commit-bot: I haz the power, 2016-11-10 23:55:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 00:20:44]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-11 00:26:20]

Description was changed from

==========
Android: Remove unnecessary members from WebsiteSettingsPopup

These were only used for a check to see if the current page was HTTPS,
which can be done more cleanly by checking the URL. This also fixes an
issue where the 'Details' link was not appearing correctly, due to a
change in the order of member initialization.

BUG=657148
==========

to

==========
Android: Remove unnecessary members from WebsiteSettingsPopup

These were only used for a check to see if the current page was HTTPS,
which can be done more cleanly by checking the URL. This also fixes an
issue where the 'Details' link was not appearing correctly, due to a
change in the order of member initialization.

BUG=657148

Committed: https://crrev.com/6beda8f1ffcd4476d5304031aa18dfd7f3b7f01a
Cr-Commit-Position: refs/heads/master@{#431399}
==========

[commit-bot: I haz the power, 2016-11-11 00:26:21]

Patchset 4 (id:??) landed as
https://crrev.com/6beda8f1ffcd4476d5304031aa18dfd7f3b7f01a
Cr-Commit-Position: refs/heads/master@{#431399}