Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: ios/chrome/browser/passwords/credential_manager_unittest.mm

Issue 2476493003: Remove FundamentalValue
Patch Set: Fix Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/passwords/credential_manager_unittest.mm
diff --git a/ios/chrome/browser/passwords/credential_manager_unittest.mm b/ios/chrome/browser/passwords/credential_manager_unittest.mm
index 8a6fa0aaa10712fa706ddb9b374112887674d71a..68cc9dc681f4c75256e54176adfd52e0778f0e76 100644
--- a/ios/chrome/browser/passwords/credential_manager_unittest.mm
+++ b/ios/chrome/browser/passwords/credential_manager_unittest.mm
@@ -320,7 +320,7 @@ TEST_F(CredentialManagerTest,
const bool zero_click = true;
static_cast<TestingPrefServiceSimple*>(stub_client_.GetPrefs())
->SetUserPref(password_manager::prefs::kCredentialsEnableAutosignin,
- new base::FundamentalValue(!zero_click));
+ new base::Value(!zero_click));
// Requesting a zero-click credential should immediately resolve the request
// with an empty credential.
@@ -346,7 +346,7 @@ TEST_F(CredentialManagerTest,
const bool zero_click = true;
static_cast<TestingPrefServiceSimple*>(stub_client_.GetPrefs())
->SetUserPref(password_manager::prefs::kCredentialsEnableAutosignin,
- new base::FundamentalValue(zero_click));
+ new base::Value(zero_click));
// Requesting a zero-click credential should try to retrieve PasswordForms
// from the PasswordStore and resolve the request with an empty Credential
@@ -374,13 +374,13 @@ TEST_F(CredentialManagerTest, ZeroClickRequestResolved) {
stub_client_.SetPasswordStore(store);
static_cast<TestingPrefServiceSimple*>(stub_client_.GetPrefs())
->SetUserPref(password_manager::prefs::kCredentialsEnableAutosignin,
- new base::FundamentalValue(zero_click));
+ new base::Value(zero_click));
// Without the first run experience, the zero-click credentials won't be
// passed to the site.
static_cast<TestingPrefServiceSimple*>(stub_client_.GetPrefs())
->SetUserPref(
password_manager::prefs::kWasAutoSignInFirstRunExperienceShown,
- new base::FundamentalValue(true));
+ new base::Value(true));
WaitForBackgroundTasks();
// Requesting a zero-click credential should retrieve a PasswordForm from the
« no previous file with comments | « ios/chrome/browser/metrics/ios_chrome_metrics_service_accessor_unittest.cc ('k') | ios/chrome/browser/ui/webui/crashes_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698