Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: extensions/renderer/argument_spec.cc

Issue 2476493003: Remove FundamentalValue
Patch Set: Fix Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/value_builder.cc ('k') | headless/public/domains/types_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/argument_spec.cc
diff --git a/extensions/renderer/argument_spec.cc b/extensions/renderer/argument_spec.cc
index f79ea8a9107f44cd2d1da2e4a275ba82ba7cac67..5354f4bd51b87ce18241c9f5594b503d4ded2d60 100644
--- a/extensions/renderer/argument_spec.cc
+++ b/extensions/renderer/argument_spec.cc
@@ -24,7 +24,7 @@ std::unique_ptr<base::Value> GetFundamentalConvertedValueHelper(
return nullptr;
if (minimum && val < minimum.value())
return nullptr;
- return base::MakeUnique<base::FundamentalValue>(val);
+ return base::MakeUnique<base::Value>(val);
}
} // namespace
@@ -180,7 +180,7 @@ std::unique_ptr<base::Value> ArgumentSpec::ConvertArgumentToFundamental(
bool b = false;
if (value->IsBoolean() &&
gin::Converter<bool>::FromV8(context->GetIsolate(), value, &b)) {
- return base::MakeUnique<base::FundamentalValue>(b);
+ return base::MakeUnique<base::Value>(b);
}
return nullptr;
}
« no previous file with comments | « extensions/common/value_builder.cc ('k') | headless/public/domains/types_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698