Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: extensions/browser/api/sockets_tcp/sockets_tcp_api.cc

Issue 2476493003: Remove FundamentalValue
Patch Set: Fix Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/sockets_tcp/sockets_tcp_api.cc
diff --git a/extensions/browser/api/sockets_tcp/sockets_tcp_api.cc b/extensions/browser/api/sockets_tcp/sockets_tcp_api.cc
index 1d956797a2479a515b65e0a71d4f0f6207aaf3cc..3895eb3ac39eefb68efced6f9ea1eb7dcade7ab1 100644
--- a/extensions/browser/api/sockets_tcp/sockets_tcp_api.cc
+++ b/extensions/browser/api/sockets_tcp/sockets_tcp_api.cc
@@ -469,8 +469,7 @@ void SocketsTcpSecureFunction::AsyncWorkStart() {
ResumableTCPSocket* socket = GetTcpSocket(params_->socket_id);
if (!socket) {
- SetResult(
- base::MakeUnique<base::FundamentalValue>(net::ERR_INVALID_ARGUMENT));
+ SetResult(base::MakeUnique<base::Value>(net::ERR_INVALID_ARGUMENT));
error_ = kSocketNotFoundError;
AsyncWorkCompleted();
return;
@@ -483,16 +482,14 @@ void SocketsTcpSecureFunction::AsyncWorkStart() {
// secure()'d.
if (socket->GetSocketType() != Socket::TYPE_TCP ||
socket->ClientStream() == NULL) {
- SetResult(
- base::MakeUnique<base::FundamentalValue>(net::ERR_INVALID_ARGUMENT));
+ SetResult(base::MakeUnique<base::Value>(net::ERR_INVALID_ARGUMENT));
error_ = kInvalidSocketStateError;
AsyncWorkCompleted();
return;
}
if (!socket->IsConnected()) {
- SetResult(
- base::MakeUnique<base::FundamentalValue>(net::ERR_INVALID_ARGUMENT));
+ SetResult(base::MakeUnique<base::Value>(net::ERR_INVALID_ARGUMENT));
error_ = kSocketNotConnectedError;
AsyncWorkCompleted();
return;
« no previous file with comments | « extensions/browser/api/socket/socket_api.cc ('k') | extensions/browser/api/storage/settings_quota_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698