Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc

Issue 2476493003: Remove FundamentalValue
Patch Set: Fix Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc
diff --git a/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc b/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc
index 87d5f303b768ee7b528543502c2040848c737fc0..046381bebd211712929274a6fe022129ddbc67d0 100644
--- a/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc
+++ b/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc
@@ -24,7 +24,7 @@
#include "testing/gtest/include/gtest/gtest.h"
using base::DictionaryValue;
-using base::FundamentalValue;
+using base::Value;
using base::ListValue;
using base::StringValue;
using base::Value;
@@ -207,7 +207,7 @@ TEST(WebRequestConditionAttributeTest, ThirdParty) {
base::MessageLoopForIO message_loop;
std::string error;
- const FundamentalValue value_true(true);
+ const Value value_true(true);
// This attribute matches only third party requests.
scoped_refptr<const WebRequestConditionAttribute> third_party_attribute =
WebRequestConditionAttribute::Create(keys::kThirdPartyKey,
@@ -217,7 +217,7 @@ TEST(WebRequestConditionAttributeTest, ThirdParty) {
ASSERT_TRUE(third_party_attribute.get());
EXPECT_EQ(std::string(keys::kThirdPartyKey),
third_party_attribute->GetName());
- const FundamentalValue value_false(false);
+ const Value value_false(false);
// This attribute matches only first party requests.
scoped_refptr<const WebRequestConditionAttribute> first_party_attribute =
WebRequestConditionAttribute::Create(keys::kThirdPartyKey,

Powered by Google App Engine
This is Rietveld 408576698