content/browser/devtools/protocol/devtools_protocol_handler_generator.py - Issue 2476493003: Remove FundamentalValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/devtools_protocol_handler_generator.py

Issue 2476493003: Remove FundamentalValue

Patch Set: Fix Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/devtools/protocol/devtools_protocol_handler_generator.py

diff --git a/content/browser/devtools/protocol/devtools_protocol_handler_generator.py b/content/browser/devtools/protocol/devtools_protocol_handler_generator.py

index 00a4d2f38b83b6122d0ee76fe080a4e958635a3f..8154158089025c9daa658071ad9536c7e72dc975 100755

--- a/content/browser/devtools/protocol/devtools_protocol_handler_generator.py

+++ b/content/browser/devtools/protocol/devtools_protocol_handler_generator.py

@@ -45,7 +45,7 @@ bool IsSupportedProtocolVersion(const std::string& version);

template<typename T>

std::unique_ptr<base::Value> CreateValue(const T& param) {

- return base::MakeUnique<base::FundamentalValue>(param);

+ return base::MakeUnique<base::Value>(param);

}

template<typename T>

« no previous file with comments | « content/browser/appcache/appcache_internals_ui.cc ('k') | content/browser/devtools/protocol_string.cc » ('j') | no next file with comments »