components/policy/core/browser/configuration_policy_pref_store_unittest.cc - Issue 2476493003: Remove FundamentalValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/browser/configuration_policy_pref_store_unittest.cc

Issue 2476493003: Remove FundamentalValue

Patch Set: Fix Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/browser/configuration_policy_handler_unittest.cc ('k') | components/policy/core/browser/proxy_policy_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/browser/configuration_policy_pref_store_unittest.cc

diff --git a/components/policy/core/browser/configuration_policy_pref_store_unittest.cc b/components/policy/core/browser/configuration_policy_pref_store_unittest.cc

index 8fae2550daf85eaf0f0691dffb1d620268b1785d..6db1f5613599ee0e8096ff2a9123772bc45c0754 100644

--- a/components/policy/core/browser/configuration_policy_pref_store_unittest.cc

+++ b/components/policy/core/browser/configuration_policy_pref_store_unittest.cc

@@ -114,7 +114,7 @@ TEST_F(ConfigurationPolicyPrefStoreBooleanTest, SetValue) {

PolicyMap policy;

policy.Set(kTestPolicy, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,

POLICY_SOURCE_CLOUD,

- base::MakeUnique<base::FundamentalValue>(false), nullptr);

+ base::MakeUnique<base::Value>(false), nullptr);

UpdateProviderPolicy(policy);

const base::Value* value = NULL;

EXPECT_TRUE(store_->GetValue(kTestPref, &value));

@@ -126,7 +126,7 @@ TEST_F(ConfigurationPolicyPrefStoreBooleanTest, SetValue) {

policy.Set(kTestPolicy, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,

POLICY_SOURCE_CLOUD,

- base::MakeUnique<base::FundamentalValue>(true), nullptr);

+ base::MakeUnique<base::Value>(true), nullptr);

UpdateProviderPolicy(policy);

value = NULL;

EXPECT_TRUE(store_->GetValue(kTestPref, &value));

@@ -153,12 +153,12 @@ TEST_F(ConfigurationPolicyPrefStoreIntegerTest, GetDefault) {

TEST_F(ConfigurationPolicyPrefStoreIntegerTest, SetValue) {

PolicyMap policy;

policy.Set(kTestPolicy, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,

- POLICY_SOURCE_CLOUD, base::MakeUnique<base::FundamentalValue>(2),

+ POLICY_SOURCE_CLOUD, base::MakeUnique<base::Value>(2),

nullptr);

UpdateProviderPolicy(policy);

const base::Value* value = NULL;

EXPECT_TRUE(store_->GetValue(kTestPref, &value));

- EXPECT_TRUE(base::FundamentalValue(2).Equals(value));

+ EXPECT_TRUE(base::Value(2).Equals(value));

}

// Exercises the policy refresh mechanism.