chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc - Issue 2476493003: Remove FundamentalValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc

Issue 2476493003: Remove FundamentalValue

Patch Set: Fix Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/settings/search_engines_handler.cc ('k') | chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc

diff --git a/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc b/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc

index b5a014ce17b338385c5a9383c5050c41938b2194..ed0470d73c728632a2738ae4dcabadc225d8325e 100644

--- a/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc

+++ b/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc

@@ -241,7 +241,7 @@ void ClearBrowsingDataHandler::OnClearingTaskFinished(

ResolveJavascriptCallback(

base::StringValue(webui_callback_id),

- base::FundamentalValue(show_notice));

+ base::Value(show_notice));

task_observer_.reset();

}

@@ -249,7 +249,7 @@ void ClearBrowsingDataHandler::OnBrowsingHistoryPrefChanged() {

CallJavascriptFunction(

"cr.webUIListenerCallback",

base::StringValue("browsing-history-pref-changed"),

- base::FundamentalValue(

+ base::Value(

profile_->GetPrefs()->GetBoolean(

prefs::kAllowDeletingBrowserHistory)));

}

@@ -279,8 +279,8 @@ void ClearBrowsingDataHandler::OnStateChanged() {

CallJavascriptFunction(

"cr.webUIListenerCallback",

base::StringValue("update-footer"),

- base::FundamentalValue(sync_service_ && sync_service_->IsSyncActive()),

- base::FundamentalValue(show_history_footer_));

+ base::Value(sync_service_ && sync_service_->IsSyncActive()),

+ base::Value(show_history_footer_));

}

void ClearBrowsingDataHandler::RefreshHistoryNotice() {