chrome/browser/ui/webui/settings/chromeos/device_keyboard_handler.cc - Issue 2476493003: Remove FundamentalValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/chromeos/device_keyboard_handler.cc

Issue 2476493003: Remove FundamentalValue

Patch Set: Fix Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/settings/chromeos/date_time_handler.cc ('k') | chrome/browser/ui/webui/settings/chromeos/device_pointer_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/chromeos/device_keyboard_handler.cc

diff --git a/chrome/browser/ui/webui/settings/chromeos/device_keyboard_handler.cc b/chrome/browser/ui/webui/settings/chromeos/device_keyboard_handler.cc

index 3fe6e66e63d7634c9b9a62aaf3ab929675d74e4b..06403f099578db76faa82c4f8d49f29063fbba61 100644

--- a/chrome/browser/ui/webui/settings/chromeos/device_keyboard_handler.cc

+++ b/chrome/browser/ui/webui/settings/chromeos/device_keyboard_handler.cc

@@ -71,8 +71,8 @@ void KeyboardHandler::HandleShowKeyboardShortcutsOverlay(

}

void KeyboardHandler::UpdateShowKeys() {

- const base::FundamentalValue has_caps_lock(HasExternalKeyboard());

- const base::FundamentalValue has_diamond_key(

+ const base::Value has_caps_lock(HasExternalKeyboard());

+ const base::Value has_diamond_key(

base::CommandLine::ForCurrentProcess()->HasSwitch(

chromeos::switches::kHasChromeOSDiamondKey));

CallJavascriptFunction("cr.webUIListenerCallback",