chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc - Issue 2476493003: Remove FundamentalValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc

Issue 2476493003: Remove FundamentalValue

Patch Set: Fix Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/invalidations_message_handler.cc ('k') | chrome/browser/ui/webui/md_downloads/downloads_list_tracker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc

diff --git a/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc b/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc

index b37d64bbab89403c6e1552b36930553098487cae..5ec61e34c43db1d93684f461580498390bca218b 100644

--- a/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc

+++ b/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc

@@ -473,8 +473,8 @@ void LocalDiscoveryUIHandler::ResetCurrentRegistration() {

}

void LocalDiscoveryUIHandler::CheckUserLoggedIn() {

- base::FundamentalValue logged_in_value(!GetSyncAccount().empty());

- base::FundamentalValue is_supervised_value(IsUserSupervisedOrOffTheRecord());

+ base::Value logged_in_value(!GetSyncAccount().empty());

+ base::Value is_supervised_value(IsUserSupervisedOrOffTheRecord());

web_ui()->CallJavascriptFunctionUnsafe("local_discovery.setUserLoggedIn",

logged_in_value, is_supervised_value);

}

@@ -579,7 +579,7 @@ void LocalDiscoveryUIHandler::SetupCloudPrintConnectorSection() {

bool cloud_print_connector_allowed =

!cloud_print_connector_enabled_.IsManaged() ||

cloud_print_connector_enabled_.GetValue();

- base::FundamentalValue allowed(cloud_print_connector_allowed);

+ base::Value allowed(cloud_print_connector_allowed);

std::string email;

Profile* profile = Profile::FromWebUI(web_ui());

@@ -587,7 +587,7 @@ void LocalDiscoveryUIHandler::SetupCloudPrintConnectorSection() {

cloud_print_connector_allowed) {

email = profile->GetPrefs()->GetString(prefs::kCloudPrintEmail);

}

- base::FundamentalValue disabled(email.empty());

+ base::Value disabled(email.empty());

base::string16 label_str;

if (email.empty()) {