chrome/browser/sync/test/integration/single_client_password_manager_setting_migrator_service_sync_test.cc - Issue 2476493003: Remove FundamentalValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/single_client_password_manager_setting_migrator_service_sync_test.cc

Issue 2476493003: Remove FundamentalValue

Patch Set: Fix Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/supervised_user/supervised_user_resource_throttle_browsertest.cc ('k') | chrome/browser/sync/test/integration/two_client_app_list_sync_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/single_client_password_manager_setting_migrator_service_sync_test.cc

diff --git a/chrome/browser/sync/test/integration/single_client_password_manager_setting_migrator_service_sync_test.cc b/chrome/browser/sync/test/integration/single_client_password_manager_setting_migrator_service_sync_test.cc

index a2b7174f1e78cff30c69208c5fa11fc7f44a6a5e..0fddb9ab07be9160101e53005df954f34eac4eb8 100644

--- a/chrome/browser/sync/test/integration/single_client_password_manager_setting_migrator_service_sync_test.cc

+++ b/chrome/browser/sync/test/integration/single_client_password_manager_setting_migrator_service_sync_test.cc

@@ -37,7 +37,7 @@ void InjectPreferenceValueToFakeServer(fake_server::FakeServer* fake_server,

const std::string& name,

bool value) {

std::string serialized;

- base::FundamentalValue bool_value(value);

+ base::Value bool_value(value);

base::JSONWriter::Write(bool_value, &serialized);

sync_pb::EntitySpecifics specifics;

sync_pb::PreferenceSpecifics* pref = nullptr;