chrome/browser/policy/default_geolocation_policy_handler_unittest.cc - Issue 2476493003: Remove FundamentalValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/default_geolocation_policy_handler_unittest.cc

Issue 2476493003: Remove FundamentalValue

Patch Set: Fix Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/policy/configuration_policy_handler_list_factory.cc ('k') | chrome/browser/policy/file_selection_dialogs_policy_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/policy/default_geolocation_policy_handler_unittest.cc

diff --git a/chrome/browser/policy/default_geolocation_policy_handler_unittest.cc b/chrome/browser/policy/default_geolocation_policy_handler_unittest.cc

index 41eb2d5f7f043858ff59bf4ab3bb7160157be525..3bb21a60d6632e3c12e8821f39b6cd05806315f9 100644

--- a/chrome/browser/policy/default_geolocation_policy_handler_unittest.cc

+++ b/chrome/browser/policy/default_geolocation_policy_handler_unittest.cc

@@ -33,7 +33,7 @@ TEST_F(DefaultGeolocationPolicyHandlerTest, AllowGeolocation) {

policy.Set(key::kDefaultGeolocationSetting,

POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,

POLICY_SOURCE_CLOUD,

- base::WrapUnique(new base::FundamentalValue(CONTENT_SETTING_ALLOW)),

+ base::WrapUnique(new base::Value(CONTENT_SETTING_ALLOW)),

nullptr);

UpdateProviderPolicy(policy);

EXPECT_FALSE(store_->GetValue(prefs::kArcLocationServiceEnabled, nullptr));

@@ -47,12 +47,12 @@ TEST_F(DefaultGeolocationPolicyHandlerTest, BlockGeolocation) {

policy.Set(key::kDefaultGeolocationSetting,

POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,

POLICY_SOURCE_CLOUD,

- base::WrapUnique(new base::FundamentalValue(CONTENT_SETTING_BLOCK)),

+ base::WrapUnique(new base::Value(CONTENT_SETTING_BLOCK)),

nullptr);

UpdateProviderPolicy(policy);

const base::Value* value = nullptr;

EXPECT_TRUE(store_->GetValue(prefs::kArcLocationServiceEnabled, &value));

- EXPECT_TRUE(base::FundamentalValue(false).Equals(value));

+ EXPECT_TRUE(base::Value(false).Equals(value));

}

TEST_F(DefaultGeolocationPolicyHandlerTest, AskGeolocation) {

@@ -63,7 +63,7 @@ TEST_F(DefaultGeolocationPolicyHandlerTest, AskGeolocation) {

policy.Set(key::kDefaultGeolocationSetting,

POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,

POLICY_SOURCE_CLOUD,

- base::WrapUnique(new base::FundamentalValue(CONTENT_SETTING_ASK)),

+ base::WrapUnique(new base::Value(CONTENT_SETTING_ASK)),

nullptr);

UpdateProviderPolicy(policy);

EXPECT_FALSE(store_->GetValue(prefs::kArcLocationServiceEnabled, nullptr));