Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3978)

Unified Diff: chrome/browser/extensions/api/preference/preference_api.cc

Issue 2476493003: Remove FundamentalValue
Patch Set: Fix Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/preference/preference_api.cc
diff --git a/chrome/browser/extensions/api/preference/preference_api.cc b/chrome/browser/extensions/api/preference/preference_api.cc
index 025bf3a80c928ac5d7a3c81689a6f222df86a20e..ee08509c37967fccb98bf1a2012bde752ebdeb6d 100644
--- a/chrome/browser/extensions/api/preference/preference_api.cc
+++ b/chrome/browser/extensions/api/preference/preference_api.cc
@@ -200,7 +200,7 @@ class InvertBooleanTransformer : public PrefTransformerInterface {
bool bool_value = false;
bool result = value->GetAsBoolean(&bool_value);
DCHECK(result);
- return new base::FundamentalValue(!bool_value);
+ return new base::Value(!bool_value);
}
};
@@ -213,10 +213,10 @@ class NetworkPredictionTransformer : public PrefTransformerInterface {
const bool pref_found = extension_pref->GetAsBoolean(&bool_value);
DCHECK(pref_found) << "Preference not found.";
if (bool_value) {
- return new base::FundamentalValue(
+ return new base::Value(
chrome_browser_net::NETWORK_PREDICTION_DEFAULT);
} else {
- return new base::FundamentalValue(
+ return new base::Value(
chrome_browser_net::NETWORK_PREDICTION_NEVER);
}
}
@@ -226,7 +226,7 @@ class NetworkPredictionTransformer : public PrefTransformerInterface {
int int_value = chrome_browser_net::NETWORK_PREDICTION_DEFAULT;
const bool pref_found = browser_pref->GetAsInteger(&int_value);
DCHECK(pref_found) << "Preference not found.";
- return new base::FundamentalValue(
+ return new base::Value(
int_value != chrome_browser_net::NETWORK_PREDICTION_NEVER);
}
};

Powered by Google App Engine
This is Rietveld 408576698