Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Unified Diff: chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc

Issue 2476493003: Remove FundamentalValue
Patch Set: Fix Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc
diff --git a/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc b/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc
index 6d22232e525d13549a9a90808878987ff067850d..1501f5fa8ada98663dcf1046ad4839c2ab094119 100644
--- a/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc
+++ b/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc
@@ -244,7 +244,7 @@ class NetworkingPrivateChromeOSApiTest : public ExtensionApiTest {
shill::kStateIdle);
service_test_->SetServiceProperty(kCellular1ServicePath,
shill::kAutoConnectProperty,
- base::FundamentalValue(true));
+ base::Value(true));
service_test_->SetServiceProperty(
kCellular1ServicePath, shill::kNetworkTechnologyProperty,
base::StringValue(shill::kNetworkTechnologyGsm));
@@ -349,13 +349,13 @@ class NetworkingPrivateChromeOSApiTest : public ExtensionApiTest {
base::StringValue("00:01:02:03:04:05"));
service_test_->SetServiceProperty(kWifi1ServicePath,
shill::kSignalStrengthProperty,
- base::FundamentalValue(40));
+ base::Value(40));
service_test_->SetServiceProperty(kWifi1ServicePath,
shill::kProfileProperty,
base::StringValue(kUser1ProfilePath));
service_test_->SetServiceProperty(kWifi1ServicePath,
shill::kConnectableProperty,
- base::FundamentalValue(true));
+ base::Value(true));
service_test_->SetServiceProperty(kWifi1ServicePath, shill::kDeviceProperty,
base::StringValue(kWifiDevicePath));
base::DictionaryValue static_ipconfig;
@@ -368,7 +368,7 @@ class NetworkingPrivateChromeOSApiTest : public ExtensionApiTest {
service_test_->SetServiceProperty(
kWifi1ServicePath, shill::kWifiFrequencyListProperty, frequencies1);
service_test_->SetServiceProperty(kWifi1ServicePath, shill::kWifiFrequency,
- base::FundamentalValue(2400));
+ base::Value(2400));
profile_test_->AddService(kUser1ProfilePath, kWifi1ServicePath);
AddService(kWifi2ServicePath, "wifi2_PSK", shill::kTypeWifi,
@@ -378,19 +378,19 @@ class NetworkingPrivateChromeOSApiTest : public ExtensionApiTest {
base::StringValue(shill::kSecurityPsk));
service_test_->SetServiceProperty(kWifi2ServicePath,
shill::kSignalStrengthProperty,
- base::FundamentalValue(80));
+ base::Value(80));
service_test_->SetServiceProperty(kWifi2ServicePath,
shill::kConnectableProperty,
- base::FundamentalValue(true));
+ base::Value(true));
AddService("stub_wimax", "wimax", shill::kTypeWimax, shill::kStateOnline);
service_test_->SetServiceProperty("stub_wimax",
shill::kSignalStrengthProperty,
- base::FundamentalValue(40));
+ base::Value(40));
service_test_->SetServiceProperty("stub_wimax", shill::kProfileProperty,
base::StringValue(kUser1ProfilePath));
service_test_->SetServiceProperty("stub_wimax", shill::kConnectableProperty,
- base::FundamentalValue(true));
+ base::Value(true));
profile_test_->AddService(kUser1ProfilePath, "stub_wimax");
base::ListValue frequencies2;
@@ -399,7 +399,7 @@ class NetworkingPrivateChromeOSApiTest : public ExtensionApiTest {
service_test_->SetServiceProperty(
kWifi2ServicePath, shill::kWifiFrequencyListProperty, frequencies2);
service_test_->SetServiceProperty(kWifi2ServicePath, shill::kWifiFrequency,
- base::FundamentalValue(5000));
+ base::Value(5000));
service_test_->SetServiceProperty(kWifi2ServicePath,
shill::kProfileProperty,
base::StringValue(kUser1ProfilePath));
@@ -482,7 +482,7 @@ IN_PROC_BROWSER_TEST_F(NetworkingPrivateChromeOSApiTest,
IN_PROC_BROWSER_TEST_F(NetworkingPrivateChromeOSApiTest, GetNetworks) {
// Hide stub_wifi2.
service_test_->SetServiceProperty(kWifi2ServicePath, shill::kVisibleProperty,
- base::FundamentalValue(false));
+ base::Value(false));
// Add a couple of additional networks that are not configured (saved).
AddService("stub_wifi3", "wifi3", shill::kTypeWifi, shill::kStateIdle);
AddService("stub_wifi4", "wifi4", shill::kTypeWifi, shill::kStateIdle);
@@ -571,7 +571,7 @@ IN_PROC_BROWSER_TEST_F(NetworkingPrivateChromeOSApiTest, GetManagedProperties) {
base::StringValue(uidata_blob));
service_test_->SetServiceProperty(kWifi2ServicePath,
shill::kAutoConnectProperty,
- base::FundamentalValue(false));
+ base::Value(false));
// Update the profile entry.
profile_test_->AddService(kUser1ProfilePath, kWifi2ServicePath);

Powered by Google App Engine
This is Rietveld 408576698