Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: chrome/browser/extensions/api/input_ime/input_ime_api.cc

Issue 2476493003: Remove FundamentalValue
Patch Set: Fix Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/input_ime/input_ime_api.cc
diff --git a/chrome/browser/extensions/api/input_ime/input_ime_api.cc b/chrome/browser/extensions/api/input_ime/input_ime_api.cc
index e1969b3423dc42edbc7d3c2144f73120f0b0d77d..5aa8b322681b726d2160c6ce117371530808958d 100644
--- a/chrome/browser/extensions/api/input_ime/input_ime_api.cc
+++ b/chrome/browser/extensions/api/input_ime/input_ime_api.cc
@@ -323,12 +323,12 @@ ExtensionFunction::ResponseAction InputImeSetCompositionFunction::Run() {
segments, &error)) {
std::unique_ptr<base::ListValue> results =
base::MakeUnique<base::ListValue>();
- results->Append(base::MakeUnique<base::FundamentalValue>(false));
+ results->Append(base::MakeUnique<base::Value>(false));
return RespondNow(ErrorWithArguments(std::move(results), error));
}
}
return RespondNow(
- OneArgument(base::MakeUnique<base::FundamentalValue>(true)));
+ OneArgument(base::MakeUnique<base::Value>(true)));
}
ExtensionFunction::ResponseAction InputImeCommitTextFunction::Run() {
@@ -344,12 +344,12 @@ ExtensionFunction::ResponseAction InputImeCommitTextFunction::Run() {
if (!engine->CommitText(params.context_id, params.text.c_str(), &error)) {
std::unique_ptr<base::ListValue> results =
base::MakeUnique<base::ListValue>();
- results->Append(base::MakeUnique<base::FundamentalValue>(false));
+ results->Append(base::MakeUnique<base::Value>(false));
return RespondNow(ErrorWithArguments(std::move(results), error));
}
}
return RespondNow(
- OneArgument(base::MakeUnique<base::FundamentalValue>(true)));
+ OneArgument(base::MakeUnique<base::Value>(true)));
}
ExtensionFunction::ResponseAction InputImeSendKeyEventsFunction::Run() {

Powered by Google App Engine
This is Rietveld 408576698