Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1670)

Unified Diff: chrome/browser/download/download_query_unittest.cc

Issue 2476493003: Remove FundamentalValue
Patch Set: Fix Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_query_unittest.cc
diff --git a/chrome/browser/download/download_query_unittest.cc b/chrome/browser/download/download_query_unittest.cc
index e47034302dc50bf61c01118275514c1288feadd1..84995e1dc0e5e6599097e5b248dd1c17a63ca064 100644
--- a/chrome/browser/download/download_query_unittest.cc
+++ b/chrome/browser/download/download_query_unittest.cc
@@ -115,14 +115,14 @@ class DownloadQueryTest : public testing::Test {
template<> void DownloadQueryTest::AddFilter(
DownloadQuery::FilterType name, bool cpp_value) {
- std::unique_ptr<base::Value> value(new base::FundamentalValue(cpp_value));
+ std::unique_ptr<base::Value> value(new base::Value(cpp_value));
CHECK(query_.AddFilter(name, *value.get()));
}
template <>
void DownloadQueryTest::AddFilter(DownloadQuery::FilterType name,
double cpp_value) {
- std::unique_ptr<base::Value> value(new base::FundamentalValue(cpp_value));
+ std::unique_ptr<base::Value> value(new base::Value(cpp_value));
CHECK(query_.AddFilter(name, *value.get()));
}
@@ -174,7 +174,7 @@ TEST_F(DownloadQueryTest, DownloadQueryTest_ZeroItems) {
}
TEST_F(DownloadQueryTest, DownloadQueryTest_InvalidFilter) {
- std::unique_ptr<base::Value> value(new base::FundamentalValue(0));
+ std::unique_ptr<base::Value> value(new base::Value(0));
EXPECT_FALSE(query()->AddFilter(static_cast<DownloadQuery::FilterType>(
std::numeric_limits<int32_t>::max()),
*value.get()));
« no previous file with comments | « chrome/browser/download/download_query.h ('k') | chrome/browser/extensions/api/automation_internal/automation_internal_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698